-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: simplify quick-start page #973
Conversation
✅ Deploy Preview for kubernetes-sigs-nfd ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
/assign @ArangoGutierrez @fmuyassarov |
ping @Tal-or @fromanirh touching the topology-updater documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
leaving the final ack to @Tal-or
Move topology-updater deployment notes to the topology-updater usage page. Also, rework the plaintext and headings a bit.
189ecff
to
8a45384
Compare
Thanks @fromanirh Rebased to resolved conflicts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ArangoGutierrez, marquiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@Tal-or this got merged a bit hastily but please see if you have any comments and I can address those |
Thank you @marquiz it LGTM no additional changes are needed |
Move topology-updater deployment notes to the topology-updater usage page. Also, rework the plaintext and headings a bit.