Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase allowed image build timeout for 500s #936

Merged

Conversation

fmuyassarov
Copy link
Member

Image build is failing otherwise as per discussion on #935 (comment).
/cc @marquiz

Signed-off-by: Feruzjon Muyassarov <[email protected]>
@k8s-ci-robot k8s-ci-robot requested a review from marquiz October 26, 2022 22:08
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 26, 2022
@netlify
Copy link

netlify bot commented Oct 26, 2022

Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit 3f33bd9
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/6359afd70e69db00085d162f
😎 Deploy Preview https://deploy-preview-936--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 26, 2022
@fmuyassarov
Copy link
Member Author

@marquiz do you have an access to rerun the failed job from Prow UI ?

Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fmuyassarov for the update. I hope this will stop sporadic (and really rare) timeouts in image building

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fmuyassarov, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2022
@marquiz
Copy link
Contributor

marquiz commented Oct 27, 2022

@marquiz do you have an access to rerun the failed job from Prow UI ?

I don't, unfortunately

@marquiz
Copy link
Contributor

marquiz commented Oct 27, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 27, 2022
@k8s-ci-robot k8s-ci-robot merged commit 671b356 into kubernetes-sigs:master Oct 27, 2022
@fmuyassarov fmuyassarov deleted the increase-build-timeout branch October 27, 2022 12:55
@marquiz marquiz mentioned this pull request Dec 20, 2022
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants