Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/api/feature: rename types #908

Merged
merged 2 commits into from
Oct 6, 2022

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Oct 6, 2022

Sync type names with NFD documentation. Aims at making the codebase
easier to follow. No functional changes, just a rename.

Split out from #903

@netlify
Copy link

netlify bot commented Oct 6, 2022

Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit 7f806e8
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/633e90efeeb45c0008dbe281
😎 Deploy Preview https://deploy-preview-908--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 6, 2022
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 6, 2022
@marquiz
Copy link
Contributor Author

marquiz commented Oct 6, 2022

/assign @ArangoGutierrez

marquiz and others added 2 commits October 6, 2022 11:25
Sync type names with NFD documentation. Aims at making the codebase
easier to follow.
Complete the previous renaming.
@marquiz marquiz force-pushed the devel/type-rename branch from 011b3a7 to 7f806e8 Compare October 6, 2022 08:25
Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 6, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4097198 into kubernetes-sigs:master Oct 6, 2022
@marquiz marquiz deleted the devel/type-rename branch October 6, 2022 10:20
@marquiz marquiz mentioned this pull request Dec 20, 2022
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants