nfd-worker: refactor gRPC connection logic #907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kubernetes-sigs-nfd ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marquiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
marquiz
force-pushed
the
devel/worker-nopublish-refactor
branch
2 times, most recently
from
4f2caa2 to
532f243
Compare
|
rebased |
|
/assign @zvonkok @ArangoGutierrez |
marquiz
force-pushed
the
devel/worker-nopublish-refactor
branch
from
532f243 to
9ff0a19
Compare
|
ping @ArangoGutierrez |
Make the NoPublish config flag a more direct control point for whether to publishing features. This patch is pre-work for adding support for other clients (upcoming new CRD API) in nfd-worker.
marquiz
force-pushed
the
devel/worker-nopublish-refactor
branch
from
9ff0a19 to
06bd6c0
Compare
|
rebased |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the NoPublish config flag a more direct control point for whether to publishing features. This patch is pre-work for adding support for other clients (upcoming new CRD API) in nfd-worker.
Split out from #903