Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/e2e: fix segfault in case no e2e config file is specified #891

Merged
merged 1 commit into from
Oct 10, 2022
Merged

test/e2e: fix segfault in case no e2e config file is specified #891

merged 1 commit into from
Oct 10, 2022

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Sep 14, 2022

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 14, 2022
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 14, 2022
fmuyassarov
fmuyassarov approved these changes Oct 10, 2022
View reviewed changes
Copy link
Member

@fmuyassarov fmuyassarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fmuyassarov, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@marquiz
Copy link
Contributor Author

marquiz commented Oct 10, 2022

/assign @zvonkok

@zvonkok
Copy link
Contributor

zvonkok commented Oct 10, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 10, 2022
@k8s-ci-robot k8s-ci-robot merged commit 37e21bf into kubernetes-sigs:master Oct 10, 2022
@marquiz marquiz deleted the fixes/e2e-no-config branch October 10, 2022 12:38
@marquiz marquiz mentioned this pull request Dec 20, 2022
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmuyassarov fmuyassarov fmuyassarov approved these changes

@adrianchiris adrianchiris Awaiting requested review from adrianchiris

@zvonkok zvonkok Awaiting requested review from zvonkok

Assignees

@zvonkok zvonkok

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marquiz @k8s-ci-robot @zvonkok @fmuyassarov