Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update kubernetes to v1.25.0 #888

Merged
merged 3 commits into from
Sep 13, 2022
Merged

Update kubernetes to v1.25.0 #888

merged 3 commits into from
Sep 13, 2022

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Sep 8, 2022

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 8, 2022
@k8s-ci-robot k8s-ci-robot requested review from kad and zvonkok September 8, 2022 07:45
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 8, 2022
@marquiz
go.mod: update kubernetes to v1.25.0
449b0b2
@marquiz
test/e2e: drop utils/kubeletconfig.go
c09225f 
The required fix is in kubernetes v1.25.0 so we can drop this local
copy.
@marquiz
nfd-client: don't use deprecated grpc.WithInsecure()
ffa3542 
Replace deprecated grpc.WithInsecure() with
grpc.WithTransportCredentials and insecure.NewCredentials(). Makes
golangci-lint pass muster.

enter the commit message for your changes. Lines starting
@marquiz
Copy link
Contributor Author

marquiz commented Sep 9, 2022

Hmm, error: failed to solve: golang:1.19-bullseye: failed to do request for arm64, let's try again
/retest

ArangoGutierrez
ArangoGutierrez approved these changes Sep 13, 2022
View reviewed changes
Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 13, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@marquiz
Copy link
Contributor Author

marquiz commented Sep 13, 2022

/retest

@k8s-ci-robot k8s-ci-robot merged commit 15f0cea into kubernetes-sigs:master Sep 13, 2022
@marquiz marquiz deleted the devel/k8s-1.25 branch September 13, 2022 15:37
@marquiz marquiz mentioned this pull request Dec 20, 2022
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArangoGutierrez ArangoGutierrez ArangoGutierrez approved these changes

@kad kad Awaiting requested review from kad

@zvonkok zvonkok Awaiting requested review from zvonkok

Assignees

@ArangoGutierrez ArangoGutierrez

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marquiz @k8s-ci-robot @ArangoGutierrez