Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go.mod: update github.com/klauspost/cpuid to v2.1.0 #851

Merged
merged 1 commit into from
Aug 9, 2022
Merged

go.mod: update github.com/klauspost/cpuid to v2.1.0 #851

merged 1 commit into from
Aug 9, 2022

Conversation

mythi
Copy link
Contributor

@mythi mythi commented Jul 19, 2022

Fixes: #844

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 19, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @mythi. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 19, 2022
@mythi mythi mentioned this pull request Jul 19, 2022
Closed
@jjacobelli
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 19, 2022
@zvonkok
Copy link
Contributor

zvonkok commented Jul 21, 2022

/lgtm bump version

@ionutnechita
Copy link

/lgtm +1

marquiz
marquiz reviewed Aug 8, 2022
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Back-to-the-office. Sorry about the delay 🙄

Looks basically good. I was just wondering do we want to advertise some of the new features in the cpuid list in the docs?

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 8, 2022
@ionutnechita
Copy link

Any updates here?

@marquiz
Copy link
Contributor

marquiz commented Aug 8, 2022

Any updates here?

I just had this one question about documentation. Any thoughts on that?

/retest

@mythi
Copy link
Contributor Author

mythi commented Aug 8, 2022

Any updates here?

I just had this one question about documentation. Any thoughts on that?

I can add those. Looks like this release added some SVM bits too but perhaps documenting those can be covered separately part of #832

@marquiz
Copy link
Contributor

marquiz commented Aug 8, 2022

I can add those

Cool, thanks. Not necessarily adding everything but only those that look likely to be useful to end users 😄

@mythi
go.mod: update github.com/klauspost/cpuid to v2.1.0
026fcb2 
The release relaxes detection of features that have non-AVX512
versions etc..

Signed-off-by: Mikko Ylinen <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 9, 2022
@mythi
Copy link
Contributor Author

mythi commented Aug 9, 2022

Added AVXVNNI to docs (that was the only one that fit)

marquiz
marquiz approved these changes Aug 9, 2022
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mythi!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 9, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marquiz, mythi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2022
@k8s-ci-robot k8s-ci-robot merged commit 4d0539c into kubernetes-sigs:master Aug 9, 2022
@marquiz marquiz mentioned this pull request Dec 20, 2022
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marquiz marquiz marquiz approved these changes

@adrianchiris adrianchiris Awaiting requested review from adrianchiris

@ArangoGutierrez ArangoGutierrez Awaiting requested review from ArangoGutierrez

Assignees

@marquiz marquiz

@jjacobelli jjacobelli

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CPUID and NFD support: AVX_VNNI
6 participants
@mythi @k8s-ci-robot @jjacobelli @zvonkok @ionutnechita @marquiz