Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/e2e: add tests for NodeFeatureRules #848

Merged
merged 1 commit into from
Oct 13, 2022
Merged

test/e2e: add tests for NodeFeatureRules #848

merged 1 commit into from
Oct 13, 2022

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Jul 8, 2022 •
edited
Loading

Add tests covering the basic functionality of NodeFeatureRule objects,
covering different feature types ("flag features", "attribute features"
and "instance features") as well as backreferencing (using the output of
previously run rules) and templating. The test relies on the "fake"
feature source and its default configuration.

Fixes: #722

Depends on #845

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 8, 2022
@marquiz
Copy link
Contributor Author

marquiz commented Jul 8, 2022

Depends on #845

/hold

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2022
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 8, 2022
@marquiz marquiz mentioned this pull request Jul 8, 2022
Closed
@marquiz marquiz force-pushed the devel/e2e-nodefeaturerule branch 2 times, most recently from 74b2455 to e9bcbbc Compare August 10, 2022 13:50
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 10, 2022
@marquiz
Copy link
Contributor Author

marquiz commented Aug 10, 2022

#845 was merged
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 10, 2022
@marquiz
Copy link
Contributor Author

marquiz commented Aug 10, 2022

Need to re-verify this
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 10, 2022
@marquiz
Copy link
Contributor Author

marquiz commented Aug 10, 2022

Tests passed on manual run
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 10, 2022
@marquiz
Copy link
Contributor Author

marquiz commented Sep 5, 2022

ping @ArangoGutierrez @zvonkok

I think we should do smth about this 😉 Especially with #540 and #863 in the works we'd need to have e2e tests to cover them. At least some baseline on top of which to implement new tests

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 14, 2022
@marquiz marquiz force-pushed the devel/e2e-nodefeaturerule branch from e9bcbbc to 625844f Compare September 14, 2022 08:03
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 14, 2022
@marquiz
Copy link
Contributor Author

marquiz commented Oct 3, 2022

ping @ArangoGutierrez @zvonkok

fmuyassarov
fmuyassarov reviewed Oct 10, 2022
View reviewed changes
Copy link
Member

@fmuyassarov fmuyassarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great addition, especially for the #910.
LGTM

test/e2e/node_feature_discovery.go Outdated Show resolved Hide resolved
test/e2e/node_feature_discovery.go Show resolved Hide resolved
@marquiz marquiz force-pushed the devel/e2e-nodefeaturerule branch from 625844f to 30d29be Compare October 11, 2022 14:12
@netlify
Copy link

netlify bot commented Oct 11, 2022 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit 6ef6112
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/63457c8f6a789d0009d5cf46
😎 Deploy Preview https://deploy-preview-848--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@marquiz
Copy link
Contributor Author

marquiz commented Oct 11, 2022

/assign ArangoGutierrez zvonkok

@marquiz
test/e2e: add tests for NodeFeatureRules
6ef6112 
Add tests covering the basic functionality of NodeFeatureRule objects,
covering different feature types ("flag features", "attribute features"
and "instance features") as well as backreferencing (using the output of
previously run rules) and templating. The test relies on the "fake"
feature source and its default configuration.
@marquiz marquiz force-pushed the devel/e2e-nodefeaturerule branch from 30d29be to 6ef6112 Compare October 11, 2022 14:24
@marquiz
Copy link
Contributor Author

marquiz commented Oct 11, 2022

Rebased in order to incorporate the latest refactoring

@fmuyassarov
Copy link
Member

LGTM

@zvonkok
Copy link
Contributor

zvonkok commented Oct 12, 2022

/lgtm works.

@marquiz
Copy link
Contributor Author

marquiz commented Oct 13, 2022

ping @zvonkok prow didn't understand the extra parameter to /lgtm 😸

@zvonkok
Copy link
Contributor

zvonkok commented Oct 13, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 13, 2022
@zvonkok
Copy link
Contributor

zvonkok commented Oct 13, 2022

/doit

@zvonkok
Copy link
Contributor

zvonkok commented Oct 13, 2022

/joke

@k8s-ci-robot
Copy link
Contributor

@zvonkok: Why do fish live in salt water? Because pepper makes them sneeze!

In response to this:

/joke

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot merged commit 0cae49e into kubernetes-sigs:master Oct 13, 2022
@marquiz marquiz deleted the devel/e2e-nodefeaturerule branch October 13, 2022 10:47
@marquiz marquiz mentioned this pull request Oct 13, 2022
Merged
@marquiz marquiz mentioned this pull request Dec 20, 2022
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmuyassarov fmuyassarov fmuyassarov left review comments

@ArangoGutierrez ArangoGutierrez Awaiting requested review from ArangoGutierrez

@zvonkok zvonkok Awaiting requested review from zvonkok

Assignees

@zvonkok zvonkok

@ArangoGutierrez ArangoGutierrez

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

E2e-tests for NodeFeatureRule objects
5 participants
@marquiz @k8s-ci-robot @fmuyassarov @zvonkok @ArangoGutierrez