source/network: ignore interface operational state #814
Conversation
Ignore the operational state of network interface when creating the network SR-IOV labels. Previously NFD only considered interfaces which were "up". Pre v0.9 we used to check the "administrative state" of interfaces (managed by the sysadmin with e.g. with ip link set dev <dev> down/up). In v0.10 we changed to checking the "operational state" of interfaces, reflecting whether the it is actually able to transfer data. Both these checks have caused confusion among users and it is more understandable and more aligned with other HW discovery functions in NFD to just drop the state check. Also, the documentation is aligned with this behavior.
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
approved
|
Ping @ArangoGutierrez @zvonkok |
|
/cherry-pick release-0.11 |
|
@marquiz: once the present PR merges, I will cherry-pick it on top of release-0.11 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ArangoGutierrez, marquiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@marquiz: new pull request created: #819 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Ignore the operational state of network interface when creating the
network SR-IOV labels. Previously NFD only considered interfaces which
were "up".
Pre v0.9 we used to check the "administrative state" of interfaces
(managed by the sysadmin with e.g. with ip link set dev down/up).
In v0.10 we changed to checking the "operational state" of interfaces,
reflecting whether the it is actually able to transfer data. Both these
checks have caused confusion among users and it is more understandable
and more aligned with other HW discovery functions in NFD to just drop
the state check. Also, the documentation is aligned with this behavior.
Fixes #812