-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
topology-updater:fix klog initialization #625
Conversation
We should use the same flag set for both program and klog arguments. Otherwise we won't be able to provide klog flags properly Signed-off-by: Talor Itzhak <[email protected]>
Hi @Tal-or. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @swatisehgal @fromanirh |
@Tal-or: GitHub didn't allow me to request PR reviews from the following users: fromanirh. Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Tal-or, looks good to me 👍
/ok-to-test
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marquiz, Tal-or The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
We should use the same flag set for both the program and klog arguments.
Otherwise, we won't be able to provide klog flags properly
Signed-off-by: Talor Itzhak [email protected]