docs: second fix to the prometheus kustomize overlay name #1518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kubernetes-sigs-nfd ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
ArangoGutierrez
requested changes
Dec 21, 2023
| @@ -35,7 +35,7 @@ The exposed metrics are | |||
| ## Kustomize | |||
|
|
|||
| To deploy NFD with metrics enabled using kustomize, you can use the | |||
| [Metrics Overlay](kustomize.md#metrics). | |||
| [prometheus overlay](kustomize.md#metrics). | |||
There was a problem hiding this comment.
The name of the overlay is in lower case. This is not a heading so I think the term "prometheus overlay" should be in lowercase
marquiz
force-pushed
the
devel/docs-fix
branch
from
8a7b841 to
6471a1f
Compare
|
/retitle docs: second fix to the prometheus kustomize overlay name |
k8s-ci-robot
changed the title
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 81430d526e18dfa080399e90d0c28dc1c5777ef2
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ArangoGutierrez, marquiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.