-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makefile: add env var controls to make test targets configurable #1489
Makefile: add env var controls to make test targets configurable #1489
Conversation
✅ Deploy Preview for kubernetes-sigs-nfd ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This PR will prevent future me leaving "NFD master and worker" on future PR's 😅 |
Thanks @ArangoGutierrez for bringing this up. When/if bringing support for this finer-grained control on what to test I think a better approach would really be to enable Ginkgo labels. We could start with simple top/high level labels like |
0b459d1
to
4414b7c
Compare
How about now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice update 👍 A few thoughts on the new version below
4414b7c
to
0188ffd
Compare
Oh, and @ArangoGutierrez please document the new variables in the table in |
0188ffd
to
3df4d32
Compare
f6933b6
to
b230714
Compare
655ff9a
to
21d4f68
Compare
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
21d4f68
to
f9195ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ArangoGutierrez for the PR. This makes running/debugging/developing e2e tests locally sooo much nicer.
/lgtm
LGTM label has been added. Git tree hash: 71414dcf30e7c86885913a26143052fe279d7845
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AhmedGrati, ArangoGutierrez, marquiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1489 +/- ##
==========================================
- Coverage 30.75% 30.66% -0.09%
==========================================
Files 58 58
Lines 7550 7571 +21
==========================================
Hits 2322 2322
- Misses 4977 4998 +21
Partials 251 251 |
No description provided.