Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: add env var controls to make test targets configurable #1489

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

ArangoGutierrez
Copy link
Contributor

No description provided.

Copy link

netlify bot commented Dec 5, 2023

Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit f9195ef
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/657348e01c60ad00093651a5
😎 Deploy Preview https://deploy-preview-1489--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 5, 2023
@ArangoGutierrez
Copy link
Contributor Author

This PR will prevent future me leaving "NFD master and worker" on future PR's 😅
/assign @marquiz

@marquiz
Copy link
Contributor

marquiz commented Dec 7, 2023

Thanks @ArangoGutierrez for bringing this up. When/if bringing support for this finer-grained control on what to test I think a better approach would really be to enable Ginkgo labels. We could start with simple top/high level labels like master, worker, topology-updater and gc for example and then add more fine grained labels later on (like nfr, nf, nrt, crd-api, grpc-api or whatever). WDYT?

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 7, 2023
@ArangoGutierrez
Copy link
Contributor Author

Thanks @ArangoGutierrez for bringing this up. When/if bringing support for this finer-grained control on what to test I think a better approach would really be to enable Ginkgo labels. We could start with simple top/high level labels like master, worker, topology-updater and gc for example and then add more fine grained labels later on (like nfr, nf, nrt, crd-api, grpc-api or whatever). WDYT?

How about now?

Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice update 👍 A few thoughts on the new version below

test/e2e/nfd_gc_test.go Outdated Show resolved Hide resolved
test/e2e/framework.go Show resolved Hide resolved
test/e2e/node_feature_discovery_test.go Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
Makefile Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
test/e2e/nfd_gc_test.go Outdated Show resolved Hide resolved
test/e2e/node_feature_discovery_test.go Outdated Show resolved Hide resolved
test/e2e/framework.go Outdated Show resolved Hide resolved
@marquiz
Copy link
Contributor

marquiz commented Dec 8, 2023

Oh, and @ArangoGutierrez please document the new variables in the table in docs/developer-guide/index.md

Makefile Outdated Show resolved Hide resolved
docs/developer-guide/index.md Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
test/e2e/node_feature_discovery_test.go Outdated Show resolved Hide resolved
test/e2e/node_feature_discovery_test.go Outdated Show resolved Hide resolved
test/e2e/node_feature_discovery_test.go Outdated Show resolved Hide resolved
@ArangoGutierrez ArangoGutierrez force-pushed the ginkofocus branch 2 times, most recently from f6933b6 to b230714 Compare December 8, 2023 15:30
@ArangoGutierrez ArangoGutierrez force-pushed the ginkofocus branch 2 times, most recently from 655ff9a to 21d4f68 Compare December 8, 2023 15:57
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ArangoGutierrez for the PR. This makes running/debugging/developing e2e tests locally sooo much nicer.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 8, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 71414dcf30e7c86885913a26143052fe279d7845

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AhmedGrati, ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ArangoGutierrez,marquiz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Merging #1489 (f9195ef) into master (bdfef6d) will decrease coverage by 0.09%.
Report is 15 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1489      +/-   ##
==========================================
- Coverage   30.75%   30.66%   -0.09%     
==========================================
  Files          58       58              
  Lines        7550     7571      +21     
==========================================
  Hits         2322     2322              
- Misses       4977     4998      +21     
  Partials      251      251              

see 2 files with indirect coverage changes

@k8s-ci-robot k8s-ci-robot merged commit 794630f into kubernetes-sigs:master Dec 8, 2023
14 checks passed
@marquiz marquiz mentioned this pull request Dec 20, 2023
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants