-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix serviceaccount handling for nfd-gc to be consistent with others #1392
Fix serviceaccount handling for nfd-gc to be consistent with others #1392
Conversation
Signed-off-by: Shiva Krishna, Merla <[email protected]>
|
✅ Deploy Preview for kubernetes-sigs-nfd ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Welcome @shivamerla! |
Hi @shivamerla. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @shivamerla for the fix. Looks good!
Could you sign the CLA so that we can get this merged?
/lgtm
/cherry-pick release-0.14
LGTM label has been added. Git tree hash: 84eae1b922f0842016279b994ced422bd8a8efac
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marquiz, shivamerla The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sorry @shivamerla I was looking some unfreshed page of this 🙈 CLA is fine |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1392 +/- ##
==========================================
+ Coverage 30.02% 30.14% +0.11%
==========================================
Files 56 56
Lines 7457 7497 +40
==========================================
+ Hits 2239 2260 +21
- Misses 4974 4991 +17
- Partials 244 246 +2 |
/cherry-pick release-0.14 |
@ArangoGutierrez: failed to push cherry-picked changes in GitHub: pushToNamedFork is not implemented in the v2 client In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.