Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-0.14] Update references to release v0.14 #1340

Merged
merged 1 commit into from
Sep 7, 2023
Merged

[release-0.14] Update references to release v0.14 #1340

merged 1 commit into from
Sep 7, 2023

Conversation

ArangoGutierrez
Copy link
Contributor

Result of

$ ./hack/prepare-release.sh -g 1.20 -k "Carlos Eduardo Arango Gutierrez (CNT) <[email protected]>" v0.14.0

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 7, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 7, 2023
@ArangoGutierrez ArangoGutierrez mentioned this pull request Sep 7, 2023
Closed
25 tasks
@ArangoGutierrez
Copy link
Contributor Author

/assign @marquiz

marquiz
marquiz requested changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's pin the go version into specific patch release. Update the makefile with go v1.20.8 (or re-run with ./hack/prepare-release.sh -b -g 1.20.8 v0.14.0)

@ArangoGutierrez
[release-0.14] Update references to release v0.14
61afda1 
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
marquiz
marquiz approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ArangoGutierrez
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 7, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b750a9c7a94ad2a73f2e9690660b0250b765b01b

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ArangoGutierrez,marquiz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ArangoGutierrez
Copy link
Contributor Author

/retest

1 similar comment
@ArangoGutierrez
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit b2c04e0 into kubernetes-sigs:release-0.14 Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marquiz marquiz marquiz approved these changes

@fmuyassarov fmuyassarov Awaiting requested review from fmuyassarov

@kad kad Awaiting requested review from kad

Assignees

@marquiz marquiz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ArangoGutierrez @k8s-ci-robot @marquiz