fix empty hugepages in some numa nodes caused no such file or directory errors

[freelizhun]

No description provided.

[netlify]

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Name	Link
🔨 Latest commit	a4ad3d4
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/64d1eb75dca1400008b97294
😎 Deploy Preview	https://deploy-preview-1287--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[k8s-ci-robot]

Welcome @freelizhun!

It looks like this is your first PR to kubernetes-sigs/node-feature-discovery 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/node-feature-discovery has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @freelizhun. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[freelizhun]

fixes #1286

[marquiz]

nit: I suggest to put the path in a variable and use that same value in the getHugepagesBytes() below to make it evident and sure that we actually use the same path

/cc @PiotrProkop @ffromani

[marquiz]

ping @freelizhun

[freelizhun]

is this ok ? @marquiz

               // Get hugepages
		huagePagePath := filepath.Join(sysBusNodeBasepath, numaNode, "hugepages")
		_, err = os.Stat(huagePagePath)
		if err != nil && os.IsNotExist(err) {
			continue
		}
		hugepageBytes, err := getHugepagesBytes(huagePagePath)

[marquiz]

Yeah, sure

[marquiz]

/ok-to-test

[marquiz]

/cherry-pick release-0.13

[k8s-infra-cherrypick-robot]

@marquiz: once the present PR merges, I will cherry-pick it on top of release-0.13 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: kylinlizhun (a4ad3d4)

[freelizhun]

/check-cla

[freelizhun]

/cc @PiotrProkop @ffromani

[ffromani]

I think this works but I'd like the explore alternative implementions

[ffromani]

would it work if we just swallow IsNotExist here?

hugepageBytes, err := getHugepagesBytes(filepath.Join(sysBusNodeBasepath, numaNode, "hugepages"))
if err != nil && os.IsNotExist(err) {
    continue
}
// ... keep the existing code

[marquiz]

Good point 😅 I think it should work

[freelizhun]

Ok, i will change it

[freelizhun]

/retest

[marquiz]

We still want to return an error is other error cases

[freelizhun]

this may be the best chocies?😅

               // Get hugepages
		huagePagePath := filepath.Join(sysBusNodeBasepath, numaNode, "hugepages")
		_, err = os.Stat(huagePagePath)
		if err != nil && os.IsNotExist(err) {
			continue
		}
		hugepageBytes, err := getHugepagesBytes(huagePagePath)

[marquiz]

How about using else?

[freelizhun]

Thank for your suggestion,@marquiz,is this ok?

// Get hugepages
		hugepageBytes, err := getHugepagesBytes(filepath.Join(sysBusNodeBasepath, numaNode, "hugepages"))
		if err != nil {
			if os.IsNotExist(err) {
				continue
			} else {
				return nil, err
			}
		}
		for n, s := range hugepageBytes {
			info[n] = s
		}

[marquiz]

Looks legit to me 👍

[marquiz]

Looks good to me
ping @ffromani @PiotrProkop

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: freelizhun, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [marquiz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ffromani]

/lgtm

thanks for the updates!

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 2cb2611d058651228f3bd41d681d2a83de8498fa

[marquiz]

/retest

[freelizhun]

Why this check failed?
pull-node-feature-discovery-verify-master — Job failed.
Need your help,ping @marquiz

[ffromani]

/test pull-node-feature-discovery-verify-master

is this a flake? Let's retry 1 (one) time

[ffromani]

can't repro locally (make ci-lint) using of couse golangci-lint golangci-lint has version v1.52.2 built with go1.20.6 from (unknown, mod sum: "h1:FrPElUUI5rrHXg1mQ7KxI1MXPAw5lBVskiz7U7a8a1A=") on (unknown)

[marquiz]

It's the stupid logcheck that is flaky, maybe it should be disabled :/
/retest

[codecov]

Codecov Report

Merging #1287 (a4ad3d4) into master (e0f10a8) will decrease coverage by 0.05%.
Report is 19 commits behind head on master.
The diff coverage is 0.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1287      +/-   ##
==========================================
- Coverage   28.93%   28.89%   -0.05%     
==========================================
  Files          54       54              
  Lines        7316     7323       +7     
==========================================
- Hits         2117     2116       -1     
- Misses       4971     4979       +8     
  Partials      228      228              

Files Changed	Coverage Δ
pkg/utils/memory_resources.go	50.00% <0.00%> (-2.00%)	⬇️

... and 5 files with indirect coverage changes

[k8s-infra-cherrypick-robot]

@marquiz: new pull request created: #1298

In response to this:

/cherry-pick release-0.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.