Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add missing mentions of extended resources and taints #1122

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Apr 11, 2023

A small update to fix some missing mentions of extended resources and taints as assets managed by NFD.

A small update to fix some missing mentions of extended resources and
taints as assets managed by NFD.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 11, 2023
@netlify
Copy link

netlify bot commented Apr 11, 2023

Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit dcbb3bc
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/64359b9ca4f0460008819bdc
😎 Deploy Preview https://deploy-preview-1122--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@marquiz
Copy link
Contributor Author

marquiz commented Apr 11, 2023

/assign @ArangoGutierrez

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 11, 2023
Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 11, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4dcfb345037add8e214935f761b3d20d14b26d34

@k8s-ci-robot k8s-ci-robot merged commit fe1db97 into kubernetes-sigs:master Apr 11, 2023
@marquiz marquiz deleted the devel/er-docs branch April 11, 2023 17:59
@marquiz marquiz mentioned this pull request Apr 12, 2023
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants