Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discover node features as annotations #1120

Closed
wants to merge 2 commits into from

Conversation

bebc
Copy link
Contributor

@bebc bebc commented Apr 9, 2023

resolve #863

#1093 has too match conflict when extender resource featrue merge to master.So I have to open another pr.
And this pr I think is more clear.Thanks to review this again.

bebc added 2 commits April 9, 2023 12:12
Extend NodeFeatureRule Spec with annotations field to allow users to
specify the list of the annotations they want to be set on the node if
rule matches.

Signed-off-by: bebc <[email protected]>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 9, 2023
@netlify
Copy link

netlify bot commented Apr 9, 2023

Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit b77db94
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/64323ed405d805000868a4c6
😎 Deploy Preview https://deploy-preview-1120--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 9, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @bebc. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 9, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bebc
Once this PR has been reviewed and has the lgtm label, please assign marquiz for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@marquiz
Copy link
Contributor

marquiz commented Apr 11, 2023

Please you don't need to open a new pull request 😱 We lose all the review history with this. You can just do git force push (git push -f ) to overwrite the old branch instead of creating a new one. Can you restore the branchin #1093 and re-open the PR?

/close

@k8s-ci-robot
Copy link
Contributor

@marquiz: Closed this PR.

In response to this:

Please you don't need to open a new pull request 😱 We lose all the review history with this. You can just do git force push (git push -f ) to overwrite the old branch instead of creating a new one. Can you restore the branchin #1093 and re-open the PR?

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discover node features as annotations
3 participants