test/e2e: fix node cleanup function #1115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The node cleanup function was not removing all NFD-labels. It omitted NFD-originated labels that used a non-default label namespace. This patch fixes the issue by getting all NFD-managed labels from the special annotation (nfd.node.kubernetes.io/feature-labels). The patch also adds the ability to cleanup extended resources in a similar way. This will be needed by future work. Also changes the order of cleaning up CRs and the node. It is the right order as cleaning up the CRs may still update the node.
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
approved
✅ Deploy Preview for kubernetes-sigs-nfd ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
k8s-ci-robot
added
the
size/L
|
/assign @ArangoGutierrez |
|
@marquiz Thank you for taking care of this 🙏 |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 3fccf491e3a0bd26a2c57a5bbbf8b19c2130cb66
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ArangoGutierrez, marquiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The node cleanup function was not removing all NFD-labels. It omitted NFD-originated labels that used a non-default label namespace. This patch fixes the issue by getting all NFD-managed labels from the special annotation (nfd.node.kubernetes.io/feature-labels).
The patch also adds the ability to cleanup extended resources in a similar way. This will be needed by future work.
Also changes the order of cleaning up CRs and the node. It is the right order as cleaning up the CRs may still update the node.