Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-0.12] helm: fix topology-updater rbac #1103

Merged
merged 2 commits into from
Mar 31, 2023
Merged

[release-0.12] helm: fix topology-updater rbac #1103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf14487
helm: fix topology-updater rbac clusterrole
marquiz Mar 9, 2023
12c2b89
helm: create topology-updater RBAC rules by default
marquiz Mar 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions deployment/helm/node-feature-discovery/templates/clusterrole.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,6 @@ rules:
- patch
- update
- list
- apiGroups:
- ""
resources:
- nodes/proxy
verbs:
- get
- apiGroups:
- nfd.k8s-sigs.io
resources:
Expand All @@ -36,7 +30,7 @@ rules:
{{- end }}

---
{{- if .Values.topologyUpdater.rbac.create }}
{{- if and .Values.topologyUpdater.enable .Values.topologyUpdater.rbac.create }}
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
Expand All @@ -51,6 +45,12 @@ rules:
verbs:
- get
- list
- apiGroups:
- ""
resources:
- nodes/proxy
verbs:
- get
- apiGroups:
- ""
resources:
Expand Down
2 changes: 1 addition & 1 deletion deployment/helm/node-feature-discovery/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,7 @@ topologyUpdater:
annotations: {}
name:
rbac:
create: false
create: true

kubeletConfigPath:
kubeletPodResourcesSockPath:
Expand Down