Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e: add codecov uploader configuration #1095

Merged
merged 1 commit into from
Apr 14, 2023
Merged

e2e: add codecov uploader configuration #1095

merged 1 commit into from
Apr 14, 2023

Conversation

fmuyassarov
Copy link
Member

@fmuyassarov fmuyassarov commented Mar 20, 2023 •
edited
Loading

e2e: add codecov uploader configuration
Depends on kubernetes/test-infra#29082.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 20, 2023
@netlify
Copy link

netlify bot commented Mar 20, 2023 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit 6ed43c2
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/6435c4352357ec0008df5a0e
😎 Deploy Preview https://deploy-preview-1095--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 20, 2023
marquiz
marquiz reviewed Mar 21, 2023
View reviewed changes
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 21, 2023
@fmuyassarov fmuyassarov changed the title test: upload coverage report by the end of unit test run e2e: add codecov uploader configuration Mar 21, 2023
@fmuyassarov fmuyassarov mentioned this pull request Mar 21, 2023
Closed
marquiz
marquiz reviewed Mar 21, 2023
View reviewed changes
codecov Outdated Show resolved Hide resolved
@fmuyassarov fmuyassarov requested review from marquiz and removed request for ArangoGutierrez and adrianchiris March 21, 2023 20:49
marquiz
marquiz reviewed Mar 22, 2023
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we want to update the scripts/test-infra/verify.sh script?

@fmuyassarov
Copy link
Member Author

fmuyassarov commented Mar 22, 2023 •
edited
Loading

Don't we want to update the scripts/test-infra/verify.sh script?

@marquiz For?

@marquiz
Copy link
Contributor

marquiz commented Mar 22, 2023

For?

Download the codecov binary and upload the report. What you had in Makefile in the earler version

@fmuyassarov
Copy link
Member Author

For?

Download the codecov binary and upload the report. What you had in Makefile in the earler version

ah, I read your comment too fast in #1095 (comment) and understood that we want it to be as part of the test infra Prow job definition. I just noticed when read your comment again :) So, currently it is done in kubernetes/test-infra#29101. We can keep wither there or in verify.sh. I don't have any preferences here.

@marquiz
Copy link
Contributor

marquiz commented Mar 31, 2023

ah, I read your comment too fast in #1095 (comment) and understood that we want it to be as part of the test infra Prow job definition. I just noticed when read your comment again :) So, currently it is done in kubernetes/test-infra#29101. We can keep wither there or in verify.sh. I don't have any preferences here.

Ach sorry, I didn't realize that. I think it would make sense to move the stuff from kubernetes/test-infra#29101 to scripts/test-infra/verify.sh. Makes it easier to read and maintain IMO, plus we already do a bunch of installation/setup steps in verify.sh so it is logical to keep all of that in one place. WDYT?

@ArangoGutierrez
Copy link
Contributor

Where are we here? Can we think of v0.13 for this? or push to v0.14?

@marquiz
Copy link
Contributor

marquiz commented Apr 4, 2023

@fmuyassarov is on PTO. We can push this beyond v0.13, not a user facing feature

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 11, 2023
@fmuyassarov
Copy link
Member Author

/hold
until keys are created

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 11, 2023
@fmuyassarov fmuyassarov mentioned this pull request Apr 11, 2023
Merged
@fmuyassarov
e2e: add codecov uploader configuration
6ed43c2 
Signed-off-by: Muyassarov, Feruzjon <[email protected]>
@fmuyassarov
Copy link
Member Author

We have one more dependency kubernetes/test-infra#29280 and then we are good to merge this one if LGTY.

marquiz
marquiz approved these changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fmuyassarov, to me looks good to be merged

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 12, 2023
@marquiz
Copy link
Contributor

marquiz commented Apr 12, 2023

/assign @ArangoGutierrez

ArangoGutierrez
ArangoGutierrez approved these changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 12, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e09fa1272186a2c86984fcc9ece752f426607870

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, fmuyassarov, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fmuyassarov
Copy link
Member Author

Let's give it a try!
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 14, 2023
@k8s-ci-robot k8s-ci-robot merged commit 018cd33 into kubernetes-sigs:master Apr 14, 2023
@fmuyassarov fmuyassarov deleted the codecov-uploader branch April 14, 2023 21:32
@marquiz marquiz mentioned this pull request Apr 18, 2023
Closed
24 tasks
@fmuyassarov fmuyassarov mentioned this pull request May 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArangoGutierrez ArangoGutierrez ArangoGutierrez approved these changes

@marquiz marquiz marquiz approved these changes

Assignees

@ArangoGutierrez ArangoGutierrez

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fmuyassarov @marquiz @ArangoGutierrez @k8s-ci-robot