kustomize: trim prune overlay #1090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kubernetes-sigs-nfd ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
marquiz
reviewed
Mar 15, 2023
There was a problem hiding this comment.
Thanks @ArangoGutierrez for the fix!
One nit about the commit message the topic "Prune" is just a bit odd to me as this is about deployment, I'd suggest something like
deployment: trim kustomize prune overlay
or
kustomize: trim prune overlay
ArangoGutierrez
changed the title
ArangoGutierrez
force-pushed
the
update_prune_helm
branch
from
b5bd1d7 to
f1c7e07
Compare
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ArangoGutierrez, marquiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
ArangoGutierrez
force-pushed
the
update_prune_helm
branch
from
f1c7e07 to
355807f
Compare
|
/assign @fmuyassarov |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: da7bfd628f88dc5724dba78cb221722fbfabcd81
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.