Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/utils: add UnmarshalJSON method to StringSetVal #1087

Merged
merged 1 commit into from
Mar 15, 2023
Merged

pkg/utils: add UnmarshalJSON method to StringSetVal #1087

merged 1 commit into from
Mar 15, 2023

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Mar 14, 2023 •
edited
Loading

Make it possible to specify values in yaml as an array like

  conf:
    - foo
    - bar

Instead of unwieldy map like

  conf:
    foo:
    bar:

@marquiz
pkg/utils: add UnmarshalJSON method to StringSetVal
4a8fc81 
Make it possible to specify values in yaml as an array like

  conf:
    - foo
    - bar

Instead of unwieldy map like

  conf:
    foo:
    bar:
@netlify
Copy link

netlify bot commented Mar 14, 2023 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit 4a8fc81
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/641036b6d4845d00093c76ef
😎 Deploy Preview https://deploy-preview-1087--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 14, 2023
@k8s-ci-robot k8s-ci-robot requested review from kad and zvonkok March 14, 2023 08:57
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2023
@marquiz marquiz mentioned this pull request Mar 14, 2023
Merged
5 tasks
@marquiz
Copy link
Contributor Author

marquiz commented Mar 14, 2023

/assign @fmuyassarov @ArangoGutierrez
/cc @AhmedGrati

@k8s-ci-robot
Copy link
Contributor

@marquiz: GitHub didn't allow me to request PR reviews from the following users: AhmedGrati.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/assign @fmuyassarov @ArangoGutierrez
/cc @AhmedGrati

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

AhmedGrati
AhmedGrati approved these changes Mar 14, 2023
View reviewed changes
Copy link

@AhmedGrati AhmedGrati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be better thanks!

@marquiz
Copy link
Contributor Author

marquiz commented Mar 15, 2023

/assign @jjacobelli

ArangoGutierrez
ArangoGutierrez approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 15, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 94fcc87a1ede33faf09932899b8fb34030eea7ba

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AhmedGrati, ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6688a2f into kubernetes-sigs:master Mar 15, 2023
@marquiz marquiz deleted the devel/strigsetval branch March 15, 2023 12:17
@marquiz marquiz mentioned this pull request Apr 12, 2023
Closed
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AhmedGrati AhmedGrati AhmedGrati approved these changes

@ArangoGutierrez ArangoGutierrez ArangoGutierrez approved these changes

@kad kad Awaiting requested review from kad

@zvonkok zvonkok Awaiting requested review from zvonkok

Assignees

@jjacobelli jjacobelli

@ArangoGutierrez ArangoGutierrez

@fmuyassarov fmuyassarov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@marquiz @k8s-ci-robot @ArangoGutierrez @AhmedGrati @jjacobelli @fmuyassarov