Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitignore: ignore codecov coverage report #1085

Merged
merged 1 commit into from
Mar 16, 2023
Merged

gitignore: ignore codecov coverage report #1085

merged 1 commit into from
Mar 16, 2023

Conversation

fmuyassarov
Copy link
Member

We don't necessarily need to keep the codecov coverage report on the git. As such, adding it to the gitignore to avoid it from accidental commiting.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 13, 2023
@netlify
Copy link

netlify bot commented Mar 13, 2023 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit 28a2be4
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/640ef62e6a1ee20008f28607
😎 Deploy Preview https://deploy-preview-1085--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 13, 2023
@fmuyassarov
Copy link
Member Author

/retest

@fmuyassarov
Copy link
Member Author

/test pull-node-feature-discovery-build-image-cross-generic

@fmuyassarov
Copy link
Member Author

/test all

@fmuyassarov
Copy link
Member Author

/cc @marquiz

@k8s-ci-robot k8s-ci-robot requested a review from marquiz March 13, 2023 10:07
@fmuyassarov
gitignore: ignore codecov coverage report
28a2be4 
We don't necessarily need to keep the codecov coverage report on the
git. As such, adding it to the gitignore to avoid it from accidental
commiting.

Signed-off-by: Muyassarov, Feruzjon <[email protected]>
marquiz
marquiz approved these changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fmuyassarov, good catch!
/retest

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fmuyassarov, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fmuyassarov
Copy link
Member Author

fmuyassarov commented Mar 13, 2023 •
edited
Loading

Prow is currently broken (not by us only) and it might take some time for it to get resolved.
Slack thread: https://kubernetes.slack.com/archives/C7J9RP96G/p1678696744216069

@marquiz
Copy link
Contributor

marquiz commented Mar 13, 2023

/retest

@fmuyassarov
Copy link
Member Author

/cc @ArangoGutierrez

@marquiz
Copy link
Contributor

marquiz commented Mar 16, 2023

/assign @jjacobelli

@jjacobelli
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 16, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8916e28c6f87d25446f8240b95db6582c65d3625

@k8s-ci-robot k8s-ci-robot merged commit c14be60 into kubernetes-sigs:master Mar 16, 2023
@fmuyassarov fmuyassarov deleted the ignore-cov-report branch March 16, 2023 08:51
@marquiz marquiz mentioned this pull request Apr 12, 2023
Closed
24 tasks
@fmuyassarov fmuyassarov mentioned this pull request May 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marquiz marquiz marquiz approved these changes

@adrianchiris adrianchiris Awaiting requested review from adrianchiris

@zvonkok zvonkok Awaiting requested review from zvonkok

@ArangoGutierrez ArangoGutierrez Awaiting requested review from ArangoGutierrez

Assignees

@jjacobelli jjacobelli

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fmuyassarov @k8s-ci-robot @marquiz @jjacobelli