Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helm: fix topology-updater rbac #1078

Merged
merged 2 commits into from
Mar 9, 2023
Merged

helm: fix topology-updater rbac #1078

merged 2 commits into from
Mar 9, 2023

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Mar 9, 2023

  • fix topology-updater rbac clusterrole
    Access to nodes/proxy resource was accidentally given to nfd-master
    (which really doesn't need it), not topology-updater.
  • create topology-updater RBAC rules by default
    Create RBAC rules if topology-updater is enabled. Previously installing
    with topologyUpdater.enable=true (without
    topologyUpdater.rbac.create=true) resulted in a crashloogbackoff as RBAC
    was missing.

marquiz added 2 commits March 9, 2023 16:15
@marquiz
helm: fix topology-updater rbac clusterrole
40d7139 
Access to nodes/proxy resource was accidentally given to nfd-master
(which really doesn't need it), not topology-updater.
@marquiz
helm: create topology-updater RBAC rules by default
40644aa 
Create RBAC rules if topology-updater is enabled. Previously installing
with topologyUpdater.enable=true (without
topologyUpdater.rbac.create=true) resulted in a crashloogbackoff as RBAC
was missing.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 9, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 9, 2023
@netlify
Copy link

netlify bot commented Mar 9, 2023 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit 40644aa
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/6409ec3c1142a3000886383e
😎 Deploy Preview https://deploy-preview-1078--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@marquiz
Copy link
Contributor Author

marquiz commented Mar 9, 2023

ping @PiotrProkop @Tal-or @jlojosnegros @ffromani

@PiotrProkop
Copy link
Contributor

LGTM!

@marquiz
Copy link
Contributor Author

marquiz commented Mar 9, 2023

/assign @ArangoGutierrez @fmuyassarov

ArangoGutierrez
ArangoGutierrez approved these changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 9, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 14d8714eee5e2eb51e0f0f878e7578ed8d31103e

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d90a4f4 into kubernetes-sigs:master Mar 9, 2023
@marquiz marquiz deleted the devel/helm branch March 9, 2023 18:14
@marquiz marquiz mentioned this pull request Mar 31, 2023
Closed
@marquiz
Copy link
Contributor Author

marquiz commented Mar 31, 2023

/cherry-pick release-0.12

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Mar 31, 2023
Merged
@k8s-infra-cherrypick-robot
Copy link

@marquiz: new pull request created: #1103

In response to this:

/cherry-pick release-0.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@marquiz marquiz mentioned this pull request Apr 12, 2023
Closed
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArangoGutierrez ArangoGutierrez ArangoGutierrez approved these changes

@adrianchiris adrianchiris Awaiting requested review from adrianchiris

Assignees

@ArangoGutierrez ArangoGutierrez

@fmuyassarov fmuyassarov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@marquiz @PiotrProkop @k8s-ci-robot @k8s-infra-cherrypick-robot @ArangoGutierrez @fmuyassarov