helm: make master port configurable #1044

AhmedGrati · 2023-01-25T20:14:59Z

Resolves #884.

netlify · 2023-01-25T20:15:04Z

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Name	Link
🔨 Latest commit	`07d5ffe`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/63da2ad7d611c30008f5449a
😎 Deploy Preview	https://deploy-preview-1044--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

k8s-ci-robot · 2023-01-25T20:15:07Z

Welcome @AhmedGrati!

It looks like this is your first PR to kubernetes-sigs/node-feature-discovery 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/node-feature-discovery has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2023-01-25T20:15:08Z

Hi @AhmedGrati. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

marquiz

Thanks for the PR @AhmedGrati. Looks good, I had just one comment regarding the gitignore

Also one nit about the commit message, the "Feat:" topic looks just baffling to me, could you change it to e.g. "helm:" (helm: make master port configurable or smth). And, could you squash the PR into one commit?

marquiz · 2023-01-26T08:28:36Z

.gitignore

@@ -2,3 +2,4 @@ bin/
 demo/helper-scripts/*.pdf
 demo/helper-scripts/*.log
 /kustomization.yaml
+.idea


What is this? At least unrelated to this PR

Yes true. However, I thought that it would be great to add it for users who use JetBrains products. I will open another PR for it if you see that it is helpful. WDYT?

marquiz

Thanks @AhmedGrati, looks good to me now 👍
/retitle helm: make master port configurable

marquiz · 2023-01-27T07:38:19Z

ping @stek29
/ok-to-test

marquiz · 2023-01-27T07:39:40Z

@AhmedGrati mdlint is not happy with the docs' changes^

marquiz · 2023-01-27T07:40:23Z

/assign @adrianchiris

AhmedGrati · 2023-01-27T09:23:18Z

/retest

AhmedGrati · 2023-01-27T09:39:02Z

@marquiz It's fixed now.

marquiz

👍

stek29 · 2023-01-27T23:20:05Z

This doesn’t solve my original issue, it was about changing containerPort and listener port in the nfd master

PiotrProkop · 2023-01-30T09:21:45Z

deployment/helm/node-feature-discovery/templates/master.yaml

@@ -65,6 +65,7 @@ spec:
          ports:
          - containerPort: 8080
            name: grpc
+            hostPort: {{ .Values.master.port }}


I don't think it is good idea to use hostPort as a default option to deploy nfd-master it will use/reserve this port on the k8s worker node. If we just want to make it configurable on which port nfd-master is listening then something like this would be enough:

command: - "/usr/bin/grpc_health_probe" - "-addr=:{{ .Values.master.port | default "8080" }}" ... ports: - containerPort: {{ .Values.master.port | default "8080" }} name: grpc

reference to best practises:
https://kubernetes.io/docs/concepts/configuration/overview/#services

Thanks @PiotrProkop, you're absolutely right 🙄 My feedback was ill-advised.

@AhmedGrati forget about my thoughtless comments, listen to @PiotrProkop

Okay, I will update it ASAP.

k8s-ci-robot · 2023-02-01T08:20:48Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AhmedGrati, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [marquiz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

PiotrProkop · 2023-02-01T08:23:20Z

docs/deployment/helm.md

@@ -108,6 +108,7 @@ We have introduced the following Chart parameters.
 | Name                        | Type    | Default                                 | description                                                                                                                              |
 |-----------------------------|---------|-----------------------------------------|------------------------------------------------------------------------------------------------------------------------------------------|
 | `master.*`                  | dict    |                                         | NFD master deployment configuration                                                                                                      |
+| `master.port` | integer | | Specifies the TCP port that nfd-master listens for incoming requests. |


I know it renders properly but this is the only line which is not aligned :( otherwise lgtm

PiotrProkop · 2023-02-01T08:24:06Z

one small nit but overall lgtm

Signed-off-by: AhmedGrati <[email protected]>

marquiz · 2023-02-01T09:13:47Z

one small nit but overall lgtm

Thanks for the review @PiotrProkop
/unhold

AhmedGrati · 2023-02-01T09:40:11Z

@PiotrProkop Thanks! It's fixed now!

PiotrProkop · 2023-02-02T16:26:47Z

LGTM

marquiz · 2023-02-03T06:51:40Z

/lgtm

k8s-ci-robot · 2023-02-03T06:51:45Z

LGTM label has been added.

Git tree hash: 7ec0ca152659e9c9023f56a2529aea0e20be1b5e

marquiz · 2023-04-14T11:33:14Z

/cherry-pick release-0.12

k8s-infra-cherrypick-robot · 2023-04-14T11:33:55Z

@marquiz: new pull request created: #1135

In response to this:

/cherry-pick release-0.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 25, 2023

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 25, 2023

k8s-ci-robot requested review from jjacobelli and fmuyassarov January 25, 2023 20:15

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 25, 2023

marquiz reviewed Jan 26, 2023

View reviewed changes

AhmedGrati force-pushed the feat-make-master-port-dynamic branch from 5c8758e to d07c5fe Compare January 26, 2023 14:37

AhmedGrati requested review from marquiz and removed request for jjacobelli and fmuyassarov January 26, 2023 14:39

marquiz approved these changes Jan 26, 2023

View reviewed changes

k8s-ci-robot changed the title ~~Feat make master port dynamic~~ helm: make master port configurable Jan 26, 2023

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2023

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 27, 2023

k8s-ci-robot assigned adrianchiris Jan 27, 2023

AhmedGrati force-pushed the feat-make-master-port-dynamic branch from d07c5fe to ec4f2ff Compare January 27, 2023 09:22

k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 27, 2023

marquiz approved these changes Jan 27, 2023

View reviewed changes

PiotrProkop reviewed Jan 30, 2023

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2023

PiotrProkop reviewed Feb 1, 2023

View reviewed changes

AhmedGrati force-pushed the feat-make-master-port-dynamic branch from e7275b4 to 517b27f Compare February 1, 2023 08:32

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 1, 2023

AhmedGrati force-pushed the feat-make-master-port-dynamic branch from 517b27f to e68bfe4 Compare February 1, 2023 08:35

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 1, 2023

AhmedGrati force-pushed the feat-make-master-port-dynamic branch 3 times, most recently from 7ad0bf1 to ab8cd4f Compare February 1, 2023 08:56

helm: make master port configurable

07d5ffe

Signed-off-by: AhmedGrati <[email protected]>

AhmedGrati force-pushed the feat-make-master-port-dynamic branch from ab8cd4f to 07d5ffe Compare February 1, 2023 09:03

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 1, 2023

AhmedGrati requested a review from PiotrProkop February 2, 2023 12:29

k8s-ci-robot assigned marquiz Feb 3, 2023

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 3, 2023

k8s-ci-robot merged commit 8df1790 into kubernetes-sigs:master Feb 3, 2023

AhmedGrati mentioned this pull request Apr 11, 2023

REQUEST: New membership for AhmedGrati kubernetes/org#4157

Closed

9 tasks

marquiz mentioned this pull request Apr 12, 2023

Release v0.13.0 #1068

Closed

24 tasks

k8s-infra-cherrypick-robot mentioned this pull request Apr 14, 2023

[release-0.12] helm: make master port configurable #1135

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

helm: make master port configurable #1044

helm: make master port configurable #1044

AhmedGrati commented Jan 25, 2023

netlify bot commented Jan 25, 2023 •

edited

Loading

k8s-ci-robot commented Jan 25, 2023

k8s-ci-robot commented Jan 25, 2023

marquiz left a comment

marquiz Jan 26, 2023

AhmedGrati Jan 26, 2023

marquiz left a comment

marquiz commented Jan 27, 2023

marquiz commented Jan 27, 2023

marquiz commented Jan 27, 2023

AhmedGrati commented Jan 27, 2023

AhmedGrati commented Jan 27, 2023

marquiz left a comment

stek29 commented Jan 27, 2023

PiotrProkop Jan 30, 2023

marquiz Jan 30, 2023

AhmedGrati Jan 30, 2023

k8s-ci-robot commented Feb 1, 2023

PiotrProkop Feb 1, 2023

PiotrProkop commented Feb 1, 2023

marquiz commented Feb 1, 2023

AhmedGrati commented Feb 1, 2023

PiotrProkop commented Feb 2, 2023

marquiz commented Feb 3, 2023

k8s-ci-robot commented Feb 3, 2023

marquiz commented Apr 14, 2023

k8s-infra-cherrypick-robot commented Apr 14, 2023

helm: make master port configurable #1044

helm: make master port configurable #1044

Conversation

AhmedGrati commented Jan 25, 2023

netlify bot commented Jan 25, 2023 • edited Loading

✅ Deploy Preview for kubernetes-sigs-nfd ready!

k8s-ci-robot commented Jan 25, 2023

k8s-ci-robot commented Jan 25, 2023

marquiz left a comment

Choose a reason for hiding this comment

marquiz Jan 26, 2023

Choose a reason for hiding this comment

AhmedGrati Jan 26, 2023

Choose a reason for hiding this comment

marquiz left a comment

Choose a reason for hiding this comment

marquiz commented Jan 27, 2023

marquiz commented Jan 27, 2023

marquiz commented Jan 27, 2023

AhmedGrati commented Jan 27, 2023

AhmedGrati commented Jan 27, 2023

marquiz left a comment

Choose a reason for hiding this comment

stek29 commented Jan 27, 2023

PiotrProkop Jan 30, 2023

Choose a reason for hiding this comment

marquiz Jan 30, 2023

Choose a reason for hiding this comment

AhmedGrati Jan 30, 2023

Choose a reason for hiding this comment

k8s-ci-robot commented Feb 1, 2023

PiotrProkop Feb 1, 2023

Choose a reason for hiding this comment

PiotrProkop commented Feb 1, 2023

marquiz commented Feb 1, 2023

AhmedGrati commented Feb 1, 2023

PiotrProkop commented Feb 2, 2023

marquiz commented Feb 3, 2023

k8s-ci-robot commented Feb 3, 2023

marquiz commented Apr 14, 2023

k8s-infra-cherrypick-robot commented Apr 14, 2023

netlify bot commented Jan 25, 2023 •

edited

Loading