Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nfd-master: always start gRPC server #1034

Merged
merged 1 commit into from
Jan 16, 2023
Merged

nfd-master: always start gRPC server #1034

merged 1 commit into from
Jan 16, 2023

Conversation

ArangoGutierrez
Copy link
Contributor

Fixes #1032

@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jan 16, 2023
@netlify
Copy link

netlify bot commented Jan 16, 2023 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit 9b3171b
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/63c59899eaf0610008655809
😎 Deploy Preview https://deploy-preview-1034--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 16, 2023
@ArangoGutierrez
Copy link
Contributor Author

/assign @marquiz

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 16, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jan 16, 2023
marquiz
marquiz reviewed Jan 16, 2023
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR @ArangoGutierrez I think this is a nice and small fixup for now. Later on, when/if dropping gRPC we probably want to do something else (sigs.k8s.io/controller-runtime/pkg/healthz or smth).

One small ask: could you open up a bit in the commit message what and why is done, i.e. start gRPC server but don't register the labeler service because we want to enable grpc health probe but don't wan't the labeling API to be enabled.

@ArangoGutierrez
nfd-master: always start gRPC server
9b3171b 
Don't register gRPC LabelServer when using the NodeFeature option, only
turn the gRPC server on for Health and Readiness probes.
@ArangoGutierrez ArangoGutierrez requested review from marquiz and removed request for adrianchiris and fmuyassarov January 16, 2023 18:35
marquiz
marquiz approved these changes Jan 16, 2023
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now!
/retitle nfd-master: always start gRPC server

@k8s-ci-robot k8s-ci-robot changed the title Skip register of gRPC LabelerServer when using -enable-nodefeature-api nfd-master: always start gRPC server Jan 16, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2023
@ArangoGutierrez
Copy link
Contributor Author

/cc adrianchiris fmuyassarov

@marquiz
Copy link
Contributor

marquiz commented Jan 16, 2023

/cherry-pick release-0.12

@k8s-infra-cherrypick-robot
Copy link

@marquiz: once the present PR merges, I will cherry-pick it on top of release-0.12 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

fmuyassarov
fmuyassarov reviewed Jan 16, 2023
View reviewed changes
Copy link
Member

@fmuyassarov fmuyassarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks @ArangoGutierrez

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 16, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d728258cc94c1d3729529c2593a2ef9dfbbfeb7c

@k8s-ci-robot k8s-ci-robot merged commit 2068fcd into kubernetes-sigs:master Jan 16, 2023
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jan 16, 2023
Merged
@k8s-infra-cherrypick-robot
Copy link

@marquiz: new pull request created: #1037

In response to this:

/cherry-pick release-0.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@marquiz marquiz mentioned this pull request Apr 12, 2023
Closed
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmuyassarov fmuyassarov fmuyassarov left review comments

@marquiz marquiz marquiz approved these changes

@adrianchiris adrianchiris Awaiting requested review from adrianchiris

Assignees

@marquiz marquiz

@fmuyassarov fmuyassarov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gRPC Health probe fails when running with -enable-nodefeature-api
5 participants
@ArangoGutierrez @k8s-ci-robot @marquiz @k8s-infra-cherrypick-robot @fmuyassarov