Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing TopologyManagerPolicy #1026

Merged
merged 2 commits into from
Jan 9, 2023
Merged

Add missing TopologyManagerPolicy #1026

merged 2 commits into from
Jan 9, 2023

Conversation

PiotrProkop
Copy link
Contributor

@PiotrProkop PiotrProkop commented Jan 9, 2023 •
edited
Loading

Version 0.0.13 of NodeResourceTopology API added missing TopologyManagerPolicy for other policies than single-numa-node. This PR adds support for those new values.

@netlify
Copy link

netlify bot commented Jan 9, 2023 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit 1bae286
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/63bc2d589f55530008f29361
😎 Deploy Preview https://deploy-preview-1026--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 9, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @PiotrProkop. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 9, 2023
ArangoGutierrez
ArangoGutierrez requested changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @PiotrProkop thanks for the PR, could you add a small description to the PR/Commit, thanks!

@ArangoGutierrez
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 9, 2023
@PiotrProkop
Copy link
Contributor Author

@ArangoGutierrez yeah, of course!

@PiotrProkop
Release v0.0.13 of NodeResourceTopology API added missing TopologyM…
1bae286 
…anagerPolicy.

Expose new policies:
* RestrictedContainerLevel
* RestrictedPodLevel
* BestEffortContainerLevel
* BestEffortPodLevel

Signed-off-by: PiotrProkop <[email protected]>
@PiotrProkop PiotrProkop force-pushed the add-missing-policies branch from b93e739 to 1bae286 Compare January 9, 2023 15:05
@PiotrProkop
Copy link
Contributor Author

Commit message and PR description changed.

@ArangoGutierrez
Copy link
Contributor

/lgtm
/assign @marquiz

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 9, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ae15f7112ecdb8eddc816297a84c3b28baead901

marquiz
marquiz approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @PiotrProkop, looks good to me 👍

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marquiz, PiotrProkop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2023
@k8s-ci-robot k8s-ci-robot merged commit 30d0952 into kubernetes-sigs:master Jan 9, 2023
@PiotrProkop PiotrProkop mentioned this pull request Mar 3, 2023
Closed
9 tasks
@marquiz marquiz mentioned this pull request Apr 12, 2023
Closed
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArangoGutierrez ArangoGutierrez ArangoGutierrez requested changes

@marquiz marquiz marquiz approved these changes

@jjacobelli jjacobelli Awaiting requested review from jjacobelli

Assignees

@marquiz marquiz

@ArangoGutierrez ArangoGutierrez

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PiotrProkop @k8s-ci-robot @ArangoGutierrez @marquiz