Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump cpuid to v2.2.3 #1023

Merged
merged 1 commit into from
Jan 2, 2023
Merged

Bump cpuid to v2.2.3 #1023

merged 1 commit into from
Jan 2, 2023

Conversation

fmuyassarov
Copy link
Member

This commit bumps cpuid version to v2.2.3 which adds support for detecting Intel Sierra Forest instructions.
Partially fixes: #947

@netlify
Copy link

netlify bot commented Dec 29, 2022 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit d9dc4b0
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/63aeb31986dfae00081117e3
😎 Deploy Preview https://deploy-preview-1023--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 29, 2022
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 29, 2022
@fmuyassarov fmuyassarov mentioned this pull request Dec 29, 2022
Closed
marquiz
marquiz reviewed Dec 30, 2022
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fmuyassarov for this. I think you could mention the new instructions in the commit message (also makes composing release notes easier 😊), and possibly in the cpuid list in docs/usage/features.md.

@marquiz
Copy link
Contributor

marquiz commented Dec 30, 2022

ping @mythi

@fmuyassarov
Bump cpuid to v2.2.3
d9dc4b0 
Bump cpuid to v2.2.3 which adds support for detecting Intel Sierra
Forest instructions like AVXIFMA, AVXNECONVERT, AVXVNNIINT8 and
CMPCCXADD.
Signed-off-by: Muyassarov, Feruzjon <[email protected]>
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 30, 2022
@fmuyassarov
Copy link
Member Author

Thanks @fmuyassarov for this. I think you could mention the new instructions in the commit message (also makes composing release notes easier blush), and possibly in the cpuid list in docs/usage/features.md.

Good point. Fixed it now, thanks.

marquiz
marquiz approved these changes Jan 2, 2023
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fmuyassarov, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 2, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4c87232a6fc1d07ff93cf9761ca547ac26762acc

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 2, 2023
@k8s-ci-robot k8s-ci-robot merged commit 79cd4fc into kubernetes-sigs:master Jan 2, 2023
@fmuyassarov fmuyassarov deleted the sfr-support branch January 2, 2023 09:42
@marquiz marquiz mentioned this pull request Apr 12, 2023
Closed
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marquiz marquiz marquiz approved these changes

@adrianchiris adrianchiris Awaiting requested review from adrianchiris

@ArangoGutierrez ArangoGutierrez Awaiting requested review from ArangoGutierrez

Assignees

@marquiz marquiz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for the Future Intel Xeon (SFR and GNR) Instructions
3 participants
@fmuyassarov @marquiz @k8s-ci-robot