test/e2e: more comprehensive test for NodeFeature objects #1016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kubernetes-sigs-nfd ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marquiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
approved
|
/assign @fmuyassarov |
k8s-ci-robot
added
the
size/L
marquiz
force-pushed
the
devel/e2e-nodefeature
branch
from
f4ca014 to
993280b
Compare
fmuyassarov
reviewed
Jan 3, 2023
Test creation of multiple NodeFeature objects per node, mocking 3rd party extensions.
marquiz
force-pushed
the
devel/e2e-nodefeature
branch
from
993280b to
099f52c
Compare
|
@fmuyassarov thanks for the review. Comments addressed. I rebased the PR on top of the latest master so that the tests are runnable again (accommodating for the NodeFeature fields becoming optional and being removed from the test data yaml). PTAL |
|
Thanks @marquiz , looks good now. |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 88c6b82a37858aeb16860ab1f61cc015bf2086d0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test creation of multiple NodeFeature objects per node, mocking 3rd party extensions.