Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: better document differences between deployment methods #1006

Merged
merged 1 commit into from
Dec 20, 2022
Merged

docs: better document differences between deployment methods #1006

merged 1 commit into from
Dec 20, 2022

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Dec 20, 2022

Fixes #651

@netlify
Copy link

netlify bot commented Dec 20, 2022 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit 27c47bd
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/63a1c6f4a9d3720008a5670f
😎 Deploy Preview https://deploy-preview-1006--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 20, 2022
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 20, 2022
@marquiz
Copy link
Contributor Author

marquiz commented Dec 20, 2022

Some improvement, I hope. Not necessarily perfect or complete.

/assign @ArangoGutierrez @fmuyassarov
ping @eliaskoromilas

eliaskoromilas
eliaskoromilas suggested changes Dec 20, 2022
View reviewed changes
Copy link
Contributor

@eliaskoromilas eliaskoromilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well-written!

docs/deployment/helm.md Outdated Show resolved Hide resolved
docs/deployment/index.md Outdated Show resolved Hide resolved
docs/deployment/index.md Outdated Show resolved Hide resolved
fmuyassarov
fmuyassarov reviewed Dec 20, 2022
View reviewed changes
docs/deployment/helm.md Outdated Show resolved Hide resolved
docs/deployment/index.md Outdated Show resolved Hide resolved
@marquiz marquiz force-pushed the documentation/deployment branch from 4c370c5 to 27c47bd Compare December 20, 2022 14:30
@marquiz
Copy link
Contributor Author

marquiz commented Dec 20, 2022

Well-written

...and hastily as you saw from all the typos 🙄

Thanks @eliaskoromilas and @fmuyassarov for really fast feedback. Comments addressed, PTAL

ArangoGutierrez
ArangoGutierrez approved these changes Dec 20, 2022
View reviewed changes
Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 20, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 92e21cd3e1d2d9ba309bbe215ab6f3866530e61d

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 921316a into kubernetes-sigs:master Dec 20, 2022
@marquiz marquiz deleted the documentation/deployment branch December 21, 2022 07:00
@marquiz marquiz mentioned this pull request Dec 21, 2022
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmuyassarov fmuyassarov fmuyassarov left review comments

@eliaskoromilas eliaskoromilas eliaskoromilas requested changes

@ArangoGutierrez ArangoGutierrez ArangoGutierrez approved these changes

@adrianchiris adrianchiris Awaiting requested review from adrianchiris

@kad kad Awaiting requested review from kad

Assignees

@ArangoGutierrez ArangoGutierrez

@fmuyassarov fmuyassarov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs: document the purpose of different deployment options
5 participants
@marquiz @k8s-ci-robot @ArangoGutierrez @eliaskoromilas @fmuyassarov