Simplify usage of ObjectMeta fields #1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kubernetes-sigs-nfd ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marquiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
|
@marquiz please rebase |
k8s-ci-robot
added
the
needs-rebase
marquiz
force-pushed
the
devel/e2e-lint
branch
from
ec46334 to
7f55a2d
Compare
k8s-ci-robot
removed
the
needs-rebase
|
Rebased |
No need to explicitly spell out ObjectMeta as it's embedded in the object types.
marquiz
force-pushed
the
devel/e2e-lint
branch
from
7f55a2d to
f5ae3fe
Compare
|
/retitle Simplify usage of ObjectMeta fields |
k8s-ci-robot
changed the title
|
I found one stupid usage of ObjectMeta in nfd-master, too, included that in this PR |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 5f99d91a4c8373f89280bfec49fc8dcbc4964560
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need to explicitly spell out ObjectMeta as it's embedded in the object types.
From #1001 (review)