Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E tests are falling #962

Closed
Tal-or opened this issue Nov 21, 2022 · 3 comments
Closed

E2E tests are falling #962

Tal-or opened this issue Nov 21, 2022 · 3 comments
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@Tal-or
Copy link
Contributor

Tal-or commented Nov 21, 2022

What happened:
Node Feature Discovery e2e tests are falling :
The falling tests are under test/e2e/node_feature_discovery.go
1.

 Nov 21 12:01:01.639: Unexpected error:
     <*errors.errorString | 0xc00147a710>: {
         s: "node \"kind-control-plane\" labels do not match expected, diff (expected vs. received): \u00a0\u00a0map[string]string{\n-\u00a0\t\"feature.node.kubernetes.io/e2e-attribute-test-1\": \"true\",\n-\u00a0\t\"feature.node.kubernetes.io/e2e-flag-test-1\":      \"true\",\n-\u00a0\t\"feature.node.kubernetes.io/e2e-instance-test-1\":  \"true\",\n\u00a0\u00a0}\n",
     }
     node "kind-control-plane" labels do not match expected, diff (expected vs. received):   map[string]string{
     -         "feature.node.kubernetes.io/e2e-attribute-test-1": "true",
     -         "feature.node.kubernetes.io/e2e-flag-test-1":      "true",
     -         "feature.node.kubernetes.io/e2e-instance-test-1":  "true",
       }
     
 occurred
 In [It] at: /go/code/github.com/k8stopologyawareschedwg/node-feature-discovery/test/e2e/node_feature_discovery.go:472
ESC[1mSTEP:ESC[0m Getting target node and checking labels ESC[38;5;243m11/21/22 12:00:43.205ESC[0m
Nov 21 12:00:43.207: FAIL: label not found!
Expected
    <bool>: false
to be true

Full Stack Trace
sigs.k8s.io/node-feature-discovery/test/e2e.glob..func1.1.5.1()
/go/code/github.com/k8stopologyawareschedwg/node-feature-discovery/test/e2e/node_feature_discovery.go:418 +0x1370

What you expected to happen:
It should passes

How to reproduce it (as minimally and precisely as possible):
Run the tests on kind cluster:
make e2e-test

Anything else we need to know?:
N/A

Environment:

  • Kubernetes version:
Client Version: v1.25.0
Kustomize Version: v4.5.7
Server Version: v1.25.0
  • Others: kind cluster
@Tal-or Tal-or added the kind/bug Categorizes issue or PR as related to a bug. label Nov 21, 2022
@marquiz
Copy link
Contributor

marquiz commented Dec 22, 2022

Fixed by #1004
ping @Tal-or
/close

@k8s-ci-robot
Copy link
Contributor

@marquiz: Closing this issue.

In response to this:

Fixed by #1004
ping @Tal-or
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Tal-or
Copy link
Contributor Author

Tal-or commented Dec 23, 2022

Thank you @marquiz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

3 participants