Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate RDT labels #1113

Closed
marquiz opened this issue Apr 4, 2023 · 12 comments · Fixed by #1530
Closed

Deprecate RDT labels #1113

marquiz opened this issue Apr 4, 2023 · 12 comments · Fixed by #1530
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Milestone

Comments

@marquiz
Copy link
Contributor

marquiz commented Apr 4, 2023

What would you like to be added:

Deprecate built-in RDT labels. The default built-in RDT labels would not be created anymore, but the RDT features would still be available for NodeFeatureRules to consume if/when somebody wants to expose them

For example:

  • v0.13: deprecate the labels
  • v0.13 + 2: remove the labels

Why is this needed:

The RDT labels are not very useful in their current form (they don't e.g indicate if the features are really enabled i.e. kernel supports them or the resctrlfs is mounted). This would also reduce the flood/clutter of labels created by NFD.

@marquiz marquiz added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 4, 2023
@ArangoGutierrez
Copy link
Contributor

/milestone v0.15

@k8s-ci-robot
Copy link
Contributor

@ArangoGutierrez: You must be a member of the kubernetes-sigs/node-feature-discovery-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Node Feature Discovery Maintainers and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v0.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@marquiz
Copy link
Contributor Author

marquiz commented Apr 22, 2023

/milestone v0.15

@k8s-ci-robot
Copy link
Contributor

@marquiz: The provided milestone is not valid for this repository. Milestones in this repository: [v0.13, v0.14]

Use /milestone clear to clear the milestone.

In response to this:

/milestone v0.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@marquiz
Copy link
Contributor Author

marquiz commented Apr 22, 2023

/milestone v0.15

@k8s-ci-robot k8s-ci-robot added this to the v0.15 milestone Apr 22, 2023
@marquiz
Copy link
Contributor Author

marquiz commented Apr 22, 2023

@ArangoGutierrez: You must be a member of the kubernetes-sigs/node-feature-discovery-maintainers

Soon we'll get this fixed 😉

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 21, 2023
@marquiz
Copy link
Contributor Author

marquiz commented Jul 21, 2023

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 21, 2023
@marquiz
Copy link
Contributor Author

marquiz commented Jul 21, 2023

IF we follow what I suggested in #1131 we'd want to move this into v0.16: RDT labels were marked as deprecated in v0.13 and we'd keep the for two more releases (v0.14 and v0.15) and finally drop in v0.16

@marquiz
Copy link
Contributor Author

marquiz commented Sep 8, 2023

/milestone v0.16

@k8s-ci-robot
Copy link
Contributor

@marquiz: The provided milestone is not valid for this repository. Milestones in this repository: [v0.15]

Use /milestone clear to clear the milestone.

In response to this:

/milestone v0.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@marquiz
Copy link
Contributor Author

marquiz commented Sep 8, 2023

/milestone v0.16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants