Merge pull request #1235 from marquiz/devel/logging

scripts/test-infra: add logcheck to verify script
kubernetes-sigs · May 31, 2023 · d64398f · d64398f
2 parents 2331b0f + 01525de
commit d64398f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/scripts/test-infra/logcheck.conf b/scripts/test-infra/logcheck.conf
@@ -0,0 +1 @@
+-structured sigs.k8s.io/node-feature-discovery/pkg/utils/grpc_log.go
diff --git a/scripts/test-infra/verify.sh b/scripts/test-infra/verify.sh
@@ -1,5 +1,7 @@
 #!/bin/bash -e
 
+this_dir=`dirname $0`
+
 # Install deps
 gobinpath="$(go env GOPATH)/bin"
 curl -sfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh| sh -s -- -b "$gobinpath" v1.52.2
@@ -15,6 +17,8 @@ curl https://keybase.io/codecovsecurity/pgp_keys.asc | gpg --no-default-keyring
 curl -Os https://uploader.codecov.io/latest/linux/codecov
 chmod +x codecov
 
+go install sigs.k8s.io/logtools/[email protected]
+
 # Run verify steps
 echo "Checking gofmt"
 make gofmt-verify
@@ -25,6 +29,9 @@ make ci-lint
 echo "Running Helm lint"
 make helm-lint
 
+echo "Running logcheck"
+logcheck -config "${this_dir}/logcheck.conf" ./cmd/... ./pkg/...  ./source/...
+
 echo "Running unit tests"
 make test
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		-structured sigs.k8s.io/node-feature-discovery/pkg/utils/grpc_log.go