hooks: disable hooks by default

We have deprecated hooks in v0.12.0 but kept it enabled by default. Starting from v0.13.x we are starting to disable it by default and plan to fully remove it in v0.14.x if there are no objections from the community. Signed-off-by: Muyassarov, Feruzjon <[email protected]>
kubernetes-sigs · Apr 24, 2023 · 4238620 · 4238620
1 parent 2356223
commit 4238620
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/deployment/components/worker-config/nfd-worker.conf.example b/deployment/components/worker-config/nfd-worker.conf.example
@@ -76,7 +76,7 @@
 #      - "vendor"
 #      - "device"
 #  local:
-#    hooksEnabled: true
+#    hooksEnabled: false
 #  custom:
 #    # The following feature demonstrates the capabilities of the matchFeatures
 #    - name: "my custom rule"

diff --git a/deployment/helm/node-feature-discovery/values.yaml b/deployment/helm/node-feature-discovery/values.yaml
@@ -185,7 +185,7 @@ worker:
     #      - "vendor"
     #      - "device"
     #  local:
-    #    hooksEnabled: true
+    #    hooksEnabled: false
     #  custom:
     #    # The following feature demonstrates the capabilities of the matchFeatures
     #    - name: "my custom rule"

diff --git a/docs/reference/worker-configuration-reference.md b/docs/reference/worker-configuration-reference.md
@@ -352,7 +352,7 @@ Example:
 ```yaml
 sources:
   local:
-    hooksEnabled: true  # true by default
+    hooksEnabled: false  # disabled by default
 ```
 
 ### sources.pci

diff --git a/docs/usage/customization-guide.md b/docs/usage/customization-guide.md
@@ -278,8 +278,8 @@ trying to execute them. A subdirectory under the hooks directory can be used,
 for example `/etc/kubernetes/node-feature-discovery/source.d/conf/`.
 
 **NOTE:** Hooks are being DEPRECATED and will be removed in a future release.
-For backward compatibility, currently hooks are enabled by default and can be
-disabled via `sources.local.hooksEnabled` field in the worker configuration.
+Starting from release v0.13.2 hooks are disabled by default and can be
+enabled via `sources.local.hooksEnabled` field in the worker configuration.
 
 ```yaml
 sources:

diff --git a/source/local/local.go b/source/local/local.go
@@ -97,7 +97,7 @@ func (s *localSource) GetLabels() (source.FeatureLabels, error) {
 // newDefaultConfig returns a new config with pre-populated defaults
 func newDefaultConfig() *Config {
 	return &Config{
-		HooksEnabled: true,
+		HooksEnabled: false,
 	}
 }