Skip to content

Commit

Permalink
deployment/kustomize: drop the sample cert-manager overlay
Browse files Browse the repository at this point in the history
Drop the deprecated and broken sample overlay. This was an example for
enabling TLS with cert-manager. However, the overlay has been broken
(and useless) since NodeFeature API was enabled by default - and gRPC
disabled - in v0.14.
  • Loading branch information
marquiz committed Jan 3, 2024
1 parent b3919f3 commit 09b5af7
Show file tree
Hide file tree
Showing 9 changed files with 2 additions and 181 deletions.
9 changes: 0 additions & 9 deletions deployment/overlays/samples/cert-manager/args.yaml

This file was deleted.

41 changes: 0 additions & 41 deletions deployment/overlays/samples/cert-manager/issuer.yaml

This file was deleted.

32 changes: 0 additions & 32 deletions deployment/overlays/samples/cert-manager/kustomization.yaml

This file was deleted.

19 changes: 0 additions & 19 deletions deployment/overlays/samples/cert-manager/master-cert.yaml

This file was deleted.

13 changes: 0 additions & 13 deletions deployment/overlays/samples/cert-manager/master-mounts.yaml

This file was deleted.

26 changes: 0 additions & 26 deletions deployment/overlays/samples/cert-manager/probes.yaml

This file was deleted.

13 changes: 0 additions & 13 deletions deployment/overlays/samples/cert-manager/worker-mounts.yaml

This file was deleted.

17 changes: 0 additions & 17 deletions deployment/overlays/samples/cert-manager/workers-cert.yaml

This file was deleted.

13 changes: 2 additions & 11 deletions docs/deployment/tls.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,7 @@ the nfd-worker has been signed by the specified root certificate (-ca-file).
Additional hardening can be enabled by specifying `-verify-node-name` in
nfd-master args, in which case nfd-master verifies that the NodeName presented
by nfd-worker matches the Common Name (CN) or a Subject Alternative Name (SAN)
of its certificate. Note that `-verify-node-name` complicates certificate
management and is not yet supported in the helm or kustomize deployment
methods.
of its certificate.

## Automated TLS certificate management using cert-manager

Expand All @@ -58,14 +56,7 @@ kubectl apply -f https://github.com/cert-manager/cert-manager/releases/download/
Alternatively, you can refer to cert-manager documentation for other
installation methods such as the Helm chart they provide.

To use the kustomize overlay to install node-feature-discovery with TLS enabled,
you may use the following:

```bash
kubectl apply -k deployment/overlays/samples/cert-manager
```

To make use of the helm chart, override `values.yaml` to enable both the
When using the Helm chart to deploy NFD, override `values.yaml` to enable both the
`tls.enabled` and `tls.certManager` options. Note that if you do not enable
`tls.certManager`, helm will successfully install the application, but
deployment will wait until certificates are manually created, as demonstrated
Expand Down

0 comments on commit 09b5af7

Please sign in to comment.