Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add minimal image #82

Merged
merged 2 commits into from
Aug 20, 2021
Merged

Add minimal image #82

merged 2 commits into from
Aug 20, 2021

Conversation

ArangoGutierrez
Copy link
Contributor

Signed-off-by: Carlos Eduardo Arango Gutierrez [email protected]

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 12, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 12, 2021
@ArangoGutierrez ArangoGutierrez mentioned this pull request Aug 12, 2021
Merged
@ArangoGutierrez
Copy link
Contributor Author

/assign @marquiz

@marquiz
Copy link
Contributor

marquiz commented Aug 12, 2021

Cool 😎 Have you tested/verified the minimal image? 😉 I haven't. At least build works, though.

One thing that I'd like to see is update the documentation. At least mention the minimal image with perhaps instructions how to deploy it.

@ArangoGutierrez
Copy link
Contributor Author

Cool sunglasses Have you tested/verified the minimal image? wink I haven't. At least build works, though.

One thing that I'd like to see is update the documentation. At least mention the minimal image with perhaps instructions how to deploy it.

Ready for a next round @marquiz

@ArangoGutierrez ArangoGutierrez force-pushed the devel/minimal_image branch 2 times, most recently from c227851 to 37457a7 Compare August 18, 2021 20:53
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 19, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 19, 2021
@ArangoGutierrez
Copy link
Contributor Author

Rebased and ready for a next round @marquiz

marquiz
marquiz reviewed Aug 19, 2021
View reviewed changes
Dockerfile
@@ -1,4 +1,5 @@
ARG BASE_IMAGE_FULL
ARG BASE_IMAGE_MINIMAL
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, one nit 😬 could you move this to the first patch where it really belongs to?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, done

@ArangoGutierrez
Add minimal image
a6a71c4 
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
@ArangoGutierrez
Document minimal image
50bf542 
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
marquiz
marquiz approved these changes Aug 20, 2021
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, now 👍
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 20, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ArangoGutierrez,marquiz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 38ce09a into kubernetes-sigs:master Aug 20, 2021
@marquiz marquiz mentioned this pull request Oct 26, 2021
Closed
13 tasks
@ArangoGutierrez ArangoGutierrez deleted the devel/minimal_image branch March 13, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marquiz marquiz marquiz approved these changes

@zvonkok zvonkok Awaiting requested review from zvonkok

Assignees

@marquiz marquiz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ArangoGutierrez @marquiz @k8s-ci-robot