Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Instance and WorkerConfig optional by default #70

Merged
merged 1 commit into from
May 26, 2021
Merged

Make Instance and WorkerConfig optional by default #70

merged 1 commit into from
May 26, 2021

Conversation

ArangoGutierrez
Copy link
Contributor

This Patchs will prevent the following warning , by making instance and workerconfig optional on the CRD, and fixing the example to be more explicit to users

$ kubectl apply -f config/samples/nfd.kubernetes.io_v1_nodefeaturediscovery.yaml
error: error validating "config/samples/nfd.kubernetes.io_v1_nodefeaturediscovery.yaml": error validating data: ValidationError(NodeFeatureDiscovery.spec): missing required field "instance" in io.kubernetes.nfd.v1.NodeFeatureDiscovery.spec; if you choose to ignore these errors, turn validation off with --validate=false

Signed-off-by: Carlos Eduardo Arango Gutierrez [email protected]

@ArangoGutierrez
Make Instance and WorkerConfig optional by default
fdb69ec 
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 25, 2021
@ArangoGutierrez
Copy link
Contributor Author

/assign @marquiz

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 25, 2021
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 25, 2021
marquiz
marquiz approved these changes May 26, 2021
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 26, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ArangoGutierrez,marquiz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f1a05b7 into kubernetes-sigs:master May 26, 2021
@marquiz marquiz mentioned this pull request Oct 26, 2021
Closed
13 tasks
@ArangoGutierrez ArangoGutierrez deleted the devel/fix_cr_sample branch March 13, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marquiz marquiz marquiz approved these changes

@zvonkok zvonkok Awaiting requested review from zvonkok

Assignees

@marquiz marquiz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ArangoGutierrez @k8s-ci-robot @marquiz