-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a minimum documentation page #68
Create a minimum documentation page #68
Conversation
9691598
to
f270f9d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @ArangoGutierrez!
Some notes and comments when quickly skimming through the patch.
f270f9d
to
3e4ca44
Compare
3e4ca44
to
9b4cb6b
Compare
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
9b4cb6b
to
8a8ca31
Compare
/assign marquiz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only open comments are related to parameterizing the operator and operand versions in docs/_config.yml
.
Also, we need some index.html in the site root. We can do e.g. redirection similar to nfd:
https://github.com/kubernetes-sigs/node-feature-discovery/blob/master/docs/index.html
70b92d7
to
87c0e0a
Compare
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
87c0e0a
to
1be5bcf
Compare
gotta say |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woops 🙄 Now that I actually look at the config here (docs/_config.yml) I see that most of the things are already parameterized (version
, release
, container_image
). Version is supposed to indicate the "release branch" (e.g. v0.2
) where as release would match the full release tag (e.g. v0.2.0
). The separate container_image
variable is in place because staging (master) and releases use a different image registry. We'd actually only need to add operand_release
there.
Also, the thinking behind the parameterization/versioning was that the master branch (what we're doing here) should actually instruct how to deploy the staging/master version of the operator. The reasoning behind is that otherwise the documentation and the version we instruct to deploy will (at some point) get out-of-sync and create confusion and/or stop to work. Getting user to deploy the latest release is handled by the documentation versioning (browsing to https://kubernetes-sigs.github.io/node-feature-discovery-operator will redirect the user to docs of the latest stable version).
Thus, my suggestion would be:
- only add
operand_release
parameter (indocs/_config.yml
) - use the existing
release
,version
andcontainer_image
elsewhere which will instruct the user to deploy the staging/devel version (for the master branch) - when this PR gets merged backport
docs/
tprelease-0.2
branch- cherry-pick all PRs to
docs/
so far (ca. 4 patches) - backport this PR (should be quite trivial, prolly simply update
_config.yml
, plus, NodeFeatureDiscovery CR needs to be copied from v0.2.0) - these^ would create a "stable" version of the documentation in gh-pages where users would land by default
- cherry-pick all PRs to
WDYT?
Change the sidebar customization so that the full version (e.g. v0.2.0) is displayed, instead of the truncated "releae branch version" (e.g. v0.2) in the top left corner of the page. The items in the version menu are unchanged and will still show the shorter form. Cherry picked from node-feature-discovery repo commit 4d19e1ab85b6cf4c6a2f6e556bf04654e4fb238e.
docs: show full version number in sidebar
remove the whitespace (around the template variable) to prevent needing to split the reference into multiple lines Co-authored-by: Markus Lehtonen <[email protected]>
/retest |
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
…e-discovery-operator into devel/readme
/label tide/merge-method-squash |
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your efforts @ArangoGutierrez! I think this is very good initial documentation 😄 👍
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ArangoGutierrez, marquiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Create a minimum documentation page Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]> * parametize docs dependant of version Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]> * docs: show full version number in sidebar Change the sidebar customization so that the full version (e.g. v0.2.0) is displayed, instead of the truncated "releae branch version" (e.g. v0.2) in the top left corner of the page. The items in the version menu are unchanged and will still show the shorter form. Cherry picked from node-feature-discovery repo commit 4d19e1ab85b6cf4c6a2f6e556bf04654e4fb238e. * beat yamllinter remove the whitespace (around the template variable) to prevent needing to split the reference into multiple lines Co-authored-by: Markus Lehtonen <[email protected]> * Create a minimum documentation page Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]> * parametize docs dependant of version Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]> * use production image Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]> * use operand_version for doc config Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]> * use container_image as example IMAGE_TAG Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]> * use release to force a better git clone Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]> * add small documentation to variable on config site Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]> * last fixes or I will unfriend Markus Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]> Co-authored-by: Markus Lehtonen <[email protected]> Co-authored-by: Kubernetes Prow Robot <[email protected]> Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
* Create a minimum documentation page Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]> * parametize docs dependant of version Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]> * docs: show full version number in sidebar Change the sidebar customization so that the full version (e.g. v0.2.0) is displayed, instead of the truncated "releae branch version" (e.g. v0.2) in the top left corner of the page. The items in the version menu are unchanged and will still show the shorter form. Cherry picked from node-feature-discovery repo commit 4d19e1ab85b6cf4c6a2f6e556bf04654e4fb238e. * beat yamllinter remove the whitespace (around the template variable) to prevent needing to split the reference into multiple lines Co-authored-by: Markus Lehtonen <[email protected]> * Create a minimum documentation page Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]> * parametize docs dependant of version Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]> * use production image Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]> * use operand_version for doc config Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]> * use container_image as example IMAGE_TAG Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]> * use release to force a better git clone Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]> * add small documentation to variable on config site Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]> * last fixes or I will unfriend Markus Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]> Co-authored-by: Markus Lehtonen <[email protected]> Co-authored-by: Kubernetes Prow Robot <[email protected]>
* Create a minimum documentation page Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]> * parametize docs dependant of version Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]> * docs: show full version number in sidebar Change the sidebar customization so that the full version (e.g. v0.2.0) is displayed, instead of the truncated "releae branch version" (e.g. v0.2) in the top left corner of the page. The items in the version menu are unchanged and will still show the shorter form. Cherry picked from node-feature-discovery repo commit 4d19e1ab85b6cf4c6a2f6e556bf04654e4fb238e. * beat yamllinter remove the whitespace (around the template variable) to prevent needing to split the reference into multiple lines Co-authored-by: Markus Lehtonen <[email protected]> * Create a minimum documentation page Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]> * parametize docs dependant of version Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]> * use production image Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]> * use operand_version for doc config Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]> * use container_image as example IMAGE_TAG Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]> * use release to force a better git clone Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]> * add small documentation to variable on config site Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]> * last fixes or I will unfriend Markus Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]> Co-authored-by: Markus Lehtonen <[email protected]> Co-authored-by: Kubernetes Prow Robot <[email protected]>
This patch cleans up the Readme and creates a very minimal documentation page
Signed-off-by: Carlos Eduardo Arango Gutierrez [email protected]