Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a minimum documentation page #68

Merged
merged 14 commits into from
Jun 2, 2021

Conversation

ArangoGutierrez
Copy link
Contributor

This patch cleans up the Readme and creates a very minimal documentation page
Signed-off-by: Carlos Eduardo Arango Gutierrez [email protected]

@k8s-ci-robot k8s-ci-robot requested a review from zvonkok May 20, 2021 21:16
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 20, 2021
@ArangoGutierrez ArangoGutierrez added documentation Improvements or additions to documentation kind/documentation Categorizes issue or PR as related to documentation. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels May 20, 2021
@ArangoGutierrez ArangoGutierrez force-pushed the devel/readme branch 7 times, most recently from 9691598 to f270f9d Compare May 20, 2021 21:45
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @ArangoGutierrez!

Some notes and comments when quickly skimming through the patch.

docs/advanced/developer-guide.md Outdated Show resolved Hide resolved
docs/advanced/developer-guide.md Outdated Show resolved Hide resolved
docs/advanced/nodefeaturediscovery.md Outdated Show resolved Hide resolved
docs/get-started/introduction.md Outdated Show resolved Hide resolved
docs/get-started/introduction.md Outdated Show resolved Hide resolved
docs/get-started/quick-start.md Outdated Show resolved Hide resolved
docs/get-started/introduction.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
@ArangoGutierrez
Copy link
Contributor Author

/assign marquiz

docs/get-started/quick-start.md Outdated Show resolved Hide resolved
docs/get-started/quick-start.md Outdated Show resolved Hide resolved
docs/advanced/nodefeaturediscovery.md Outdated Show resolved Hide resolved
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only open comments are related to parameterizing the operator and operand versions in docs/_config.yml.

Also, we need some index.html in the site root. We can do e.g. redirection similar to nfd:
https://github.com/kubernetes-sigs/node-feature-discovery/blob/master/docs/index.html

Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
@ArangoGutierrez
Copy link
Contributor Author

gotta say verify-docs is... very difficult to please

Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woops 🙄 Now that I actually look at the config here (docs/_config.yml) I see that most of the things are already parameterized (version, release, container_image). Version is supposed to indicate the "release branch" (e.g. v0.2) where as release would match the full release tag (e.g. v0.2.0). The separate container_image variable is in place because staging (master) and releases use a different image registry. We'd actually only need to add operand_release there.

Also, the thinking behind the parameterization/versioning was that the master branch (what we're doing here) should actually instruct how to deploy the staging/master version of the operator. The reasoning behind is that otherwise the documentation and the version we instruct to deploy will (at some point) get out-of-sync and create confusion and/or stop to work. Getting user to deploy the latest release is handled by the documentation versioning (browsing to https://kubernetes-sigs.github.io/node-feature-discovery-operator will redirect the user to docs of the latest stable version).

Thus, my suggestion would be:

  • only add operand_release parameter (in docs/_config.yml)
  • use the existing release, version and container_image elsewhere which will instruct the user to deploy the staging/devel version (for the master branch)
  • when this PR gets merged backport docs/ tp release-0.2 branch
    • cherry-pick all PRs to docs/ so far (ca. 4 patches)
    • backport this PR (should be quite trivial, prolly simply update _config.yml, plus, NodeFeatureDiscovery CR needs to be copied from v0.2.0)
    • these^ would create a "stable" version of the documentation in gh-pages where users would land by default

WDYT?

docs/advanced/nodefeaturediscovery.md Outdated Show resolved Hide resolved
marquiz and others added 3 commits June 2, 2021 07:19
Change the sidebar customization so that the full version (e.g. v0.2.0)
is displayed, instead of the truncated "releae branch version" (e.g.
v0.2) in the top left corner of the page. The items in the version menu
are unchanged and will still show the shorter form.

Cherry picked from node-feature-discovery repo commit
4d19e1ab85b6cf4c6a2f6e556bf04654e4fb238e.
docs: show full version number in sidebar
remove the whitespace (around the template variable) to prevent needing to split the reference into multiple lines

Co-authored-by: Markus Lehtonen <[email protected]>
@ArangoGutierrez
Copy link
Contributor Author

/retest

Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
@ArangoGutierrez
Copy link
Contributor Author

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jun 2, 2021
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your efforts @ArangoGutierrez! I think this is very good initial documentation 😄 👍

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 2, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ArangoGutierrez,marquiz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit b5efc6f into kubernetes-sigs:master Jun 2, 2021
@ArangoGutierrez ArangoGutierrez deleted the devel/readme branch June 2, 2021 16:51
ArangoGutierrez added a commit to ArangoGutierrez/node-feature-discovery-operator that referenced this pull request Jun 2, 2021
* Create a minimum documentation page

Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>

* parametize docs dependant of version

Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>

* docs: show full version number in sidebar

Change the sidebar customization so that the full version (e.g. v0.2.0)
is displayed, instead of the truncated "releae branch version" (e.g.
v0.2) in the top left corner of the page. The items in the version menu
are unchanged and will still show the shorter form.

Cherry picked from node-feature-discovery repo commit
4d19e1ab85b6cf4c6a2f6e556bf04654e4fb238e.

* beat yamllinter

remove the whitespace (around the template variable) to prevent needing to split the reference into multiple lines

Co-authored-by: Markus Lehtonen <[email protected]>

* Create a minimum documentation page

Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>

* parametize docs dependant of version

Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>

* use production image

Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>

* use operand_version for doc config

Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>

* use container_image as example IMAGE_TAG

Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>

* use release to force a better git clone

Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>

* add small documentation to variable on config site

Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>

* last fixes or I will unfriend Markus

Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>

Co-authored-by: Markus Lehtonen <[email protected]>
Co-authored-by: Kubernetes Prow Robot <[email protected]>
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
@marquiz marquiz mentioned this pull request Oct 26, 2021
13 tasks
ArangoGutierrez added a commit to ArangoGutierrez/node-feature-discovery-operator that referenced this pull request Feb 11, 2022
* Create a minimum documentation page

Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>

* parametize docs dependant of version

Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>

* docs: show full version number in sidebar

Change the sidebar customization so that the full version (e.g. v0.2.0)
is displayed, instead of the truncated "releae branch version" (e.g.
v0.2) in the top left corner of the page. The items in the version menu
are unchanged and will still show the shorter form.

Cherry picked from node-feature-discovery repo commit
4d19e1ab85b6cf4c6a2f6e556bf04654e4fb238e.

* beat yamllinter

remove the whitespace (around the template variable) to prevent needing to split the reference into multiple lines

Co-authored-by: Markus Lehtonen <[email protected]>

* Create a minimum documentation page

Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>

* parametize docs dependant of version

Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>

* use production image

Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>

* use operand_version for doc config

Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>

* use container_image as example IMAGE_TAG

Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>

* use release to force a better git clone

Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>

* add small documentation to variable on config site

Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>

* last fixes or I will unfriend Markus

Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>

Co-authored-by: Markus Lehtonen <[email protected]>
Co-authored-by: Kubernetes Prow Robot <[email protected]>
ArangoGutierrez added a commit to ArangoGutierrez/node-feature-discovery-operator that referenced this pull request Mar 19, 2023
* Create a minimum documentation page

Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>

* parametize docs dependant of version

Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>

* docs: show full version number in sidebar

Change the sidebar customization so that the full version (e.g. v0.2.0)
is displayed, instead of the truncated "releae branch version" (e.g.
v0.2) in the top left corner of the page. The items in the version menu
are unchanged and will still show the shorter form.

Cherry picked from node-feature-discovery repo commit
4d19e1ab85b6cf4c6a2f6e556bf04654e4fb238e.

* beat yamllinter

remove the whitespace (around the template variable) to prevent needing to split the reference into multiple lines

Co-authored-by: Markus Lehtonen <[email protected]>

* Create a minimum documentation page

Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>

* parametize docs dependant of version

Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>

* use production image

Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>

* use operand_version for doc config

Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>

* use container_image as example IMAGE_TAG

Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>

* use release to force a better git clone

Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>

* add small documentation to variable on config site

Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>

* last fixes or I will unfriend Markus

Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>

Co-authored-by: Markus Lehtonen <[email protected]>
Co-authored-by: Kubernetes Prow Robot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. documentation Improvements or additions to documentation kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants