Add serviceport var to CRD #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
ArangoGutierrez
force-pushed
the
devel/master_port
branch
from
ba6fd58
to
565899e
Compare
marquiz
reviewed
Apr 19, 2021
| @@ -35,6 +37,8 @@ type ResourceStatus int | |||
| const ( | |||
| Ready ResourceStatus = iota | |||
| NotReady | |||
|
|
|||
| servicePort int = 12000 | |||
There was a problem hiding this comment.
Suggest slight renaming:
Suggested change
| servicePort int = 12000 | |
| defaultServicePort int = 12000 |
This patch allows users to modify the nfd-master Service port via CRD with the variable Operand.ServicePort , will deafult to 12000 when not defined Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
ArangoGutierrez
force-pushed
the
devel/master_port
branch
from
565899e
to
2c8e920
Compare
marquiz
reviewed
Apr 20, 2021
…controls.go Co-authored-by: Markus Lehtonen <[email protected]>
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
|
/label tide/merge-method-squash |
marquiz
approved these changes
Apr 20, 2021
There was a problem hiding this comment.
Nice improvement @ArangoGutierrez!
/label tide/merge-method-squash
/lgtm
k8s-ci-robot
added
tide/merge-method-squash
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ArangoGutierrez, marquiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Evalle
pushed a commit
to Evalle/node-feature-discovery-operator
that referenced
this pull request
Oct 13, 2021
* Add serviceport var to CRD This patch allows users to modify the nfd-master Service port via CRD with the variable Operand.ServicePort , will deafult to 12000 when not defined Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]> * check for "nfd-master" only once at controllers/nodefeaturediscovery_controls.go Co-authored-by: Markus Lehtonen <[email protected]> * run goftm Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]> Co-authored-by: Markus Lehtonen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch allows users to modify the nfd-master Service port via CRD
with the variable Operand.ServicePort , will deafult to 12000 when not
defined
Signed-off-by: Carlos Eduardo Arango Gutierrez [email protected]