Add support for Core-Config #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
|
/assign marquiz |
marquiz
requested changes
Apr 13, 2021
ArangoGutierrez
force-pushed
the
devel/core-config
branch
from
2f523db
to
0ba1897
Compare
marquiz
reviewed
Apr 14, 2021
Operand NFD Patch kubernetes-sigs/node-feature-discovery#433 changed the way nfd-worker get's arguments, this patch looks to update the operator to the new way of running the nfd-worker Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
ArangoGutierrez
force-pushed
the
devel/core-config
branch
from
0ba1897
to
2a56d18
Compare
marquiz
approved these changes
Apr 14, 2021
There was a problem hiding this comment.
Looks good now. Thanks for you perseverance @ArangoGutierrez 😄
/lgtm
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ArangoGutierrez, marquiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I am a fast learner |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Operand NFD Patch kubernetes-sigs/node-feature-discovery#433 changed the way nfd-worker get's arguments, this patch looks to update the operator to the new way of running the nfd-worker
Signed-off-by: Carlos Eduardo Arango Gutierrez [email protected]