This repository has been archived by the owner on Jun 26, 2023. It is now read-only.
Update HCR & HNSR to move NS creation to HNSR #550
Merged
+303
−695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
size/XL
yiqigao217
force-pushed
the
cascadingDelete-HNSR
branch
from
31b8416 to
38283a6
Compare
k8s-ci-robot
removed
the
needs-rebase
|
/assign @adrianludwin |
yiqigao217
force-pushed
the
cascadingDelete-HNSR
branch
from
38283a6 to
73f2c03
Compare
yiqigao217
force-pushed
the
cascadingDelete-HNSR
branch
from
73f2c03 to
09093f8
Compare
k8s-ci-robot
added
size/XXL
yiqigao217
force-pushed
the
cascadingDelete-HNSR
branch
2 times, most recently
from
0a52325 to
133aa65
Compare
k8s-ci-robot
added
size/XL
yiqigao217
changed the title
This commit removes the hc.Spec.RequiredChildren field and the enable-hns-reconciler flag. It also moves the creation of the owned (previously requiredChild) namespaces from HC Reconciler (HCR) to HNS Reconciler (HNSR). The logic in HCR is cleaned up to adapt this change. Tested with the current and updated integration tests by "make test". Also manually tested the 'k hns describe'. The HNS_MISSING condition was set when I deleted the HNS instance in the owner. The owned namespace got recreated after I deleted it, which means the new watch in HNSR is working.
yiqigao217
force-pushed
the
cascadingDelete-HNSR
branch
from
133aa65 to
b287126
Compare
|
/lgtm |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
lgtm
|
/lgtm |
k8s-ci-robot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrianludwin, rjbez17, yiqigao217 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the hc.Spec.RequiredChildren field and the
enable-hns-reconciler flag. It also moves the creation of the owned
(previously requiredChild) namespaces from HC Reconciler (HCR) to HNS
Reconciler (HNSR). The logic in HCR is cleaned up to adapt this change.
Tested with the current and updated integration tests by "make test".
Also manually tested the 'k hns describe'. The HNS_MISSING condition was
set when I deleted the HNS instance in the owner. The owned namespace
got recreated after I deleted it, which means the new watch in HNSR is
working.
Fully described in #552
Part of #457
Fixes #479