Skip to content
This repository has been archived by the owner on Jun 26, 2023. It is now read-only.

Add timeoutSeconds patch for webhook configuration #1039

Conversation

tcnksm
Copy link
Contributor

@tcnksm tcnksm commented Aug 21, 2020

Context: #1023

Add timeoutSeconds patch for webhook configuration.

Currently, controller-tools does not support timetouSeconds marker (I'm sending patches for it). So just add kustomize patches for it.

Test

Executing the following command (which is executed in cloudbuild.yaml) on my local PC,

cd multi-tenancy/incubator/hnc
mkdir out
cd out
touch kustomization.yaml
kustomize edit add resource ../config/default
kustomize build . -o ./hnc-manager.yaml

This is the output of hnc-manager.yaml. You can see timeoutSecond is added.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 21, 2020
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 21, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @tcnksm. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 21, 2020
@adrianludwin
Copy link
Contributor

Thanks Taichi. Would you please confirm how you tested it? Eg, did you generate the manifests, did you observe the timeout working correctly, etc?

@tcnksm
Copy link
Contributor Author

tcnksm commented Aug 24, 2020

Thanks Taichi. Would you please confirm how you tested it? Eg, did you generate the manifests, did you observe the timeout working correctly, etc?

I updated the description of the PR and put the output of the current manifest. https://gist.github.com/tcnksm/1bfb91d412c7635315559b3f318806fb

@adrianludwin
Copy link
Contributor

/ok-to-test
/approve
/lgtm

I'll backport this to 0.5.2.

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 24, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 24, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrianludwin, tcnksm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 24, 2020
@k8s-ci-robot k8s-ci-robot merged commit 39c9550 into kubernetes-retired:master Aug 24, 2020
@adrianludwin adrianludwin added this to the hnc-v0.6 milestone Sep 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants