Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release chart v3.8.2 #967

Merged

Conversation

stevehipwell
Copy link
Contributor

What this PR does / why we need it:
This PR releases the chart changes made in #960.

Which issue(s) this PR fixes:
Fixes #965.

yuvraj9 and others added 2 commits February 22, 2022 15:34
…sigs#960)

* chart - making liveness and readiness probe configurable

* changing chart condition from if to with

* chore[chart]: Update release CI

Signed-off-by: Steve Hipwell <[email protected]>

* chart - making liveness and readiness probe configurable

* Remove asterisk from v0.6.0 version required

* Fix charts and helm e2e test

Signed-off-by: JunYang <[email protected]>

Co-authored-by: Steve Hipwell <[email protected]>
Co-authored-by: Marek Siarkowicz <[email protected]>
Co-authored-by: JunYang <[email protected]>
(cherry picked from commit bdcadeb)
Signed-off-by: Steve Hipwell <[email protected]>
(cherry picked from commit d5fbc0d)
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 22, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2022
@stevehipwell
Copy link
Contributor Author

/retest

Copy link

@liangyuanpeng liangyuanpeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work, LGTM

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liangyuanpeng, stevehipwell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@serathius
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 23, 2022
@k8s-ci-robot k8s-ci-robot merged commit 193ce3b into kubernetes-sigs:release-0.6 Feb 23, 2022
@stevehipwell stevehipwell deleted the release-chart-v3-8-2 branch February 23, 2022 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants