Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore support for log specific flags in release-0.6 branch #942

Merged
merged 1 commit into from
Jan 28, 2022
Merged

Restore support for log specific flags in release-0.6 branch #942

merged 1 commit into from
Jan 28, 2022

Conversation

yangjunmyfm192085
Copy link
Contributor

What this PR does / why we need it:
Restore support for log specific flags in release-0.6 branch
/cc @serathius
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
part of #941

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 28, 2022
@yangjunmyfm192085
Copy link
Contributor Author

/test pull-metrics-server-test-version

yangjunmyfm192085
yangjunmyfm192085 commented Jan 28, 2022
View reviewed changes
Copy link
Contributor Author

@yangjunmyfm192085 yangjunmyfm192085 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little confused, Why does the pull-metrics-server-test-version test fail so frequently, for the same reason

IMAGE=gcr.io/k8s-staging-metrics-server/metrics-server-s390x:0b88642818de7674519fd87d6bd84c89 EXPECTED_ARCH=s390x EXPECTED_VERSION=v0.6.0 ./test/test-image.sh
WARNING: The requested image's platform (linux/s390x) does not match the detected host platform (linux/amd64) and no specific platform was requested
WARNING: The requested image's platform (linux/s390x) does not match the detected host platform (linux/amd64) and no specific platform was requested
cat: ./docs/command-line-flags.txt: No such file or directory
make[1]: *** [Makefile:133: test-image] Error 1
make[1]: Leaving directory '/home/prow/go/src/sigs.k8s.io/metrics-server'
make: *** [Makefile:137: test-image-all] Error 2
+ EXIT_VALUE=2
+ set +o xtrace

/cc @serathius

yangjunmyfm192085
yangjunmyfm192085 commented Jan 28, 2022
View reviewed changes
Copy link
Contributor Author

@yangjunmyfm192085 yangjunmyfm192085 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retest

serathius
serathius reviewed Jan 28, 2022
View reviewed changes
test/test-image.sh
@@ -20,3 +20,12 @@ if [[ "${CONTAINER_VERSION}" != "${EXPECTED_VERSION}" ]] ; then
exit 1
fi

CLI_HELP="$(docker run --rm ${IMAGE} --help | sed 's/[ \t]*$//')"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code should not be added without adding ./docs/command-line-flags.txt

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's even needed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. I have updated.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 28, 2022
@yangjunmyfm192085
Copy link
Contributor Author

/test pull-metrics-server-test-version

@serathius
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 28, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: serathius, yangjunmyfm192085

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2022
@k8s-ci-robot k8s-ci-robot merged commit 07aa1ba into kubernetes-sigs:release-0.6 Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serathius serathius serathius left review comments

Assignees

@serathius serathius

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yangjunmyfm192085 @serathius @k8s-ci-robot