Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix document: replace a broken link on README.md #1041

Merged
merged 2 commits into from
Jun 12, 2022
Merged

Fix document: replace a broken link on README.md #1041

merged 2 commits into from
Jun 12, 2022

Conversation

Shunpoco
Copy link
Contributor

@Shunpoco Shunpoco commented Jun 11, 2022 •
edited
Loading

What this PR does / why we need it:
I found that the link returns 404. So I want to fix it.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 11, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: Shunpoco / name: Shunsuke Tokunaga (0a5676d)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 11, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @Shunpoco!

It looks like this is your first PR to kubernetes-sigs/metrics-server 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/metrics-server has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 11, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @Shunpoco. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 11, 2022
yangjunmyfm192085
yangjunmyfm192085 reviewed Jun 12, 2022
View reviewed changes
README.md
@@ -49,7 +49,7 @@ distributions. Please ensure that your cluster distribution supports these requi

[reachable from kube-apiserver]: https://kubernetes.io/docs/concepts/architecture/master-node-communication/#master-to-cluster
[enable an aggregation layer]: https://kubernetes.io/docs/tasks/access-kubernetes-api/configure-aggregation-layer/
[authentication and authorization]: https://kubernetes.io/docs/reference/command-line-tools-reference/kubelet-authentication-authorization/
[authentication and authorization]: https://kubernetes.io/docs/reference/access-authn-authz/kubelet-authn-authz/
Copy link
Contributor

@yangjunmyfm192085 yangjunmyfm192085 Jun 12, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.
I think the L148-L150 have also failed, could you repaired them together?

metrics-server/README.md

Line 148 in 115e821

[Kubernetes monitoring architecture]: https://github.com/kubernetes/community/blob/master/contributors/design-proposals/instrumentation/monitoring_architecture.md

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed.
As the document said, the design proposal is already archived. So I replaced links with the archive repository.

yangjunmyfm192085
yangjunmyfm192085 reviewed Jun 12, 2022
View reviewed changes
Copy link
Contributor

@yangjunmyfm192085 yangjunmyfm192085 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 12, 2022
@serathius
Copy link
Contributor

/retest
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 12, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: serathius, Shunpoco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2022
@k8s-ci-robot k8s-ci-robot merged commit 878da75 into kubernetes-sigs:master Jun 12, 2022
@Shunpoco Shunpoco deleted the fix-readme-link branch June 13, 2022 00:16
yangjunmyfm192085 added a commit to yangjunmyfm192085/metrics-server that referenced this pull request Jun 13, 2022
@yangjunmyfm192085
Fix document: replace a broken link on README.md(cherrypick:kubernete…
b2b66e2 
…s-sigs#1041)
@yangjunmyfm192085 yangjunmyfm192085 mentioned this pull request Jun 13, 2022
Merged
k8s-ci-robot added a commit that referenced this pull request Jun 13, 2022
@k8s-ci-robot
Merge pull request #1042 from yangjunmyfm192085/updatereadme
d365766 
Fix document: replace a broken link on README.md(cherrypick:https:#1041)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yangjunmyfm192085 yangjunmyfm192085 yangjunmyfm192085 left review comments

@dgrisonnet dgrisonnet Awaiting requested review from dgrisonnet

@serathius serathius Awaiting requested review from serathius

Assignees

@serathius serathius

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Shunpoco @k8s-ci-robot @serathius @yangjunmyfm192085