-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Add test case for DurationFrom #1285
test: Add test case for DurationFrom #1285
Conversation
Welcome @mayooot! |
Hi @mayooot. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for k8s-kwok canceled.
|
/ok-to-test |
/retest |
Please format it and squash all commits
|
Update pkg/utils/expression/value_duration_from_test.go Co-authored-by: Shiming Zhang <[email protected]>
b710f2a
to
a9d4b1a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mayooot, wzshiming The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/kind cleanup |
/release-note-none |
What type of PR is this?
/kind feature
/kind cleanup
What this PR does / why we need it:
This PR adds additional test cases for the
DurationFrom
feature to enhance test coverage.There is a second use of
DurationFrom
in the kwok document: specifying a specific time using a string type, but there is no test in the code for this case.DurationFrom is the expression used to get the value. If it is a time.Time type, getting the value will be minus time.Now() to get DurationMilliseconds If it is a string type, the value get will be parsed by time.ParseDuration.
link: https://kwok.sigs.k8s.io/docs/generated/apis/#kwok.x-k8s.io/v1alpha1.ExpressionFromSource