Add load_restrictor flag. #998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: monopole The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
monopole
force-pushed
the
addLoadRestrictorFlag
branch
from
545e52f to
b91d83d
Compare
monopole
force-pushed
the
addLoadRestrictorFlag
branch
from
b91d83d to
3b8c5ee
Compare
Closed
|
Thanks a lot, @monopole. Together with plugins this restores my pre-2.0 usecase. |
pohly
added a commit
to pohly/pmem-CSI
that referenced
this pull request
May 2, 2019
This allows us to remove the workaround for patch files because kubernetes-sigs/kustomize#998 added support for loading patch files outside of the root. While at it, this fixes two things: - incorrect comment (Go 1.11 already had good enough module support) - dependencies were to complicated and prevented rebuilding files when changing the kustomize version
pohly
added a commit
to pohly/pmem-CSI
that referenced
this pull request
May 2, 2019
This allows us to remove the workaround for patch files because kubernetes-sigs/kustomize#998 added support for loading patch files outside of the root. While at it, this fixes two things: - incorrect comment (Go 1.11 already had good enough module support) - dependencies were to complicated and prevented rebuilding files when changing the kustomize version
pohly
added a commit
to pohly/pmem-CSI
that referenced
this pull request
May 3, 2019
This allows us to remove the workaround for patch files because kubernetes-sigs/kustomize#998 added support for loading patch files outside of the root. While at it, this fixes two things: - incorrect comment (Go 1.11 already had good enough module support) - dependencies were to complicated and prevented rebuilding files when changing the kustomize version
chuyd
pushed a commit
to chuyd/pmem-CSI
that referenced
this pull request
May 16, 2019
This allows us to remove the workaround for patch files because kubernetes-sigs/kustomize#998 added support for loading patch files outside of the root. While at it, this fixes two things: - incorrect comment (Go 1.11 already had good enough module support) - dependencies were to complicated and prevented rebuilding files when changing the kustomize version
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reimpose the restriction removed in #995, but provide a flag to override:
will allow loading of data files outside the kustomization root. The flag's default value is
rootOnly, which prevents loading from outside the root.If the kustomization target is remote (e.g.
$diris actually a github URL), the flag has no effect - loading is always restricted to the kustomization root for remote kustomizations.Fixes #985
Fixes #937
Fixes #868
Fixes #851
Fixes #766
Related #759