-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Annotation to Control Inline List Conversion in Kustomize Resources #5744
Conversation
This PR has multiple commits, and the default merge method is: merge. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: isarns The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Welcome @isarns! |
Hi @isarns. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/close |
@isarns: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This MR introduces a new annotation to Kustomize resources:
kustomize.config.k8s.io/convertToInlineList
. When set tofalse
, this annotation prevents objects with names ending in "List" from being converted to inline resources, allowing them to be treated at face value.Changes:
kustomize.config.k8s.io/convertToInlineList: false
annotation.Example:
For example, the resource definition ManagedPrefixList does not require conversion to an inline list, and with this annotation, Kustomize will respect its original format.
Issues Addressed:
Feedback Request:
As someone new to Golang, I understand that this MR might not be perfect. I welcome any guidance, suggestions, or improvements from the community to refine this feature further.