-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CLI page to Reference Section #5304
Conversation
Welcome @ncapps! |
Hi @ncapps. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor comment.
This PR has multiple commits, and the default merge method is: merge. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @bugoverdose, Thanks for your input! I updated everything per your comments. |
Start operations section Refine operations section Add common operations Address comments
/ok-to-test |
Hi @bugoverdose, I believe that I addressed your comments. Would you please review when you get a chance? If you are good with the changes, would you please add a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi sorry I was a bit late. Can you check the Reference/CLI/_index.md page?
It was added from another PR, and I think we should migrate the content in Reference/kustomize_cli.md
to Reference/CLI/_index.md
Update the CLI description
@bugoverdose Thank you for pointing this out. I moved the content to the CLI index. |
/lgtm |
/label tide/merge-method-squash |
Looks great, thanks @ncapps! Taking an iterative approach, anyone who wants more detail can add it later. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: annasong20, ncapps The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This change consolidates
Commands
content on a single page to resolve #5278.I used the kubectl CLI page as inspiration for the content layout.